The Samba-Bugzilla – Bug 389
allow multiple exclude arguments with smbclient tar -Xr options
Last modified: 2005-11-14 09:29:51 UTC
Using smbclient tar -X without -r allows you to use multiple exclude
files. If smbclient is compiled without HAVE_REGEX_H, using smbclient
tar -rX only uses the first exclude argument; the rest are silently
The submitted patch adds a new function mask_match_list() that calls
mask_match() on each entry of cliplist, returning TRUE if at least
one matches. This allows smbclient tar -Xr to support multiple exclude
arguments. (In the HAVE_REGEX_H case I presume the user can build a
single compound regex using "|" to match multiple names.)
This patch adds the new function in lib/util.c. Alternatively, the
same function could be static and included directly in client/clitar.c
(like clipfind()). (I assume I don't need to patch include/proto.h
since that is auto-generated.)
Created attachment 119 [details]
patch applied to 3.0/HEAD. Thanks. Much appreciated.
originally reported against one of the 3.0.0rc[1-4] releases.
Cleaning up non-production versions.
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.