Bug 389 - allow multiple exclude arguments with smbclient tar -Xr options
Summary: allow multiple exclude arguments with smbclient tar -Xr options
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: smbclient (show other bugs)
Version: 3.0.0preX
Hardware: All Linux
: P3 normal
Target Milestone: none
Assignee: Gerald (Jerry) Carter (dead mail address)
QA Contact:
Depends on:
Reported: 2003-09-02 08:57 UTC by Craig Barratt
Modified: 2005-11-14 09:29 UTC (History)
0 users

See Also:

proposed patch (2.05 KB, patch)
2003-09-02 08:58 UTC, Craig Barratt
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Barratt 2003-09-02 08:57:32 UTC
Using smbclient tar -X without -r allows you to use multiple exclude
files.  If smbclient is compiled without HAVE_REGEX_H, using smbclient
tar -rX only uses the first exclude argument; the rest are silently

The submitted patch adds a new function mask_match_list() that calls
mask_match() on each entry of cliplist[], returning TRUE if at least
one matches.  This allows smbclient tar -Xr to support multiple exclude
arguments.  (In the HAVE_REGEX_H case I presume the user can build a
single compound regex using "|" to match multiple names.)

This patch adds the new function in lib/util.c.  Alternatively, the
same function could be static and included directly in client/clitar.c
(like clipfind()).  (I assume I don't need to patch include/proto.h
since that is auto-generated.)
Comment 1 Craig Barratt 2003-09-02 08:58:05 UTC
Created attachment 119 [details]
proposed patch
Comment 2 Gerald (Jerry) Carter (dead mail address) 2004-03-19 06:54:51 UTC
patch applied to 3.0/HEAD.  Thanks.  Much appreciated.
Comment 3 Gerald (Jerry) Carter (dead mail address) 2005-02-07 09:04:46 UTC
originally reported against one of the 3.0.0rc[1-4] releases.
Cleaning up non-production versions.
Comment 4 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:19:07 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.
Comment 5 Gerald (Jerry) Carter (dead mail address) 2005-11-14 09:29:51 UTC
database cleanup