Bug 3809 - Feature Request: Individual log file per module
Summary: Feature Request: Individual log file per module
Status: CLOSED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 2.6.8
Hardware: Other Linux
: P3 enhancement (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-26 15:53 UTC by Master Abi
Modified: 2006-10-15 13:26 UTC (History)
1 user (show)

See Also:


Attachments
The log-file settings can be set differently for each module (14.92 KB, patch)
2006-06-07 18:04 UTC, Wayne Davison
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Master Abi 2006-05-26 15:53:32 UTC
Currently the 'log file' directive is global, hence only 1 log file can be created.

In addition to this, having a each module log to seperate log file would be beneficial when large amounts of modules are used. We have >200 module entries and have to script to get at the information.

I guess 'transfer logging' would then be ignored if 'log file' directive is present in the module section. If 'log file' is not present in the per module, it then logs to the global log or syslog.
Comment 1 Steve French 2006-05-29 16:24:57 UTC
In the trace, this was mounted over loopback

Kernel is Linux version 2.6.17-rc5-default

Samba is Version 3.0.22-9-SUSE-SLES10

Although I could repeat it with current Samba 3 rc later tonight (it fails the same way).
Comment 2 Steve French 2006-05-29 21:08:54 UTC
ignore the previous comment - it was for another defect
Comment 3 Wayne Davison 2006-06-07 17:49:36 UTC
I've worked up a patch that makes both "log file" and "syslog facility" per-module settings instead of globals.  I didn't see any need to affect "transfer logging", as this was already a per-module setting, and the user can set it to "yes" or "no" either globally or locally, as desired.
Comment 4 Wayne Davison 2006-06-07 18:04:18 UTC
Created attachment 1954 [details]
The log-file settings can be set differently for each module
Comment 5 Wayne Davison 2006-07-09 22:13:56 UTC
This is now in the CVS version.