Bug 3785 - pam_winbind does not compile
pam_winbind does not compile
Status: RESOLVED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: winbind
3.0.23
x86 FreeBSD
: P3 critical
: none
Assigned To: Samba Bugzilla Account
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-18 02:22 UTC by Rashid N. Achilov
Modified: 2006-08-04 12:03 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rashid N. Achilov 2006-05-18 02:22:00 UTC
Compiling nsswitch/pam_winbind.c with -fPIC -DPIC
nsswitch/pam_winbind.c: In function `winbind_auth_request':
nsswitch/pam_winbind.c:407: error: `PATH_MAX' undeclared (first use in this function)
nsswitch/pam_winbind.c:407: error: (Each undeclared identifier is reported only once
nsswitch/pam_winbind.c:407: error: for each function it appears in.)
nsswitch/pam_winbind.c: In function `pam_sm_acct_mgmt':
nsswitch/pam_winbind.c:981: warning: passing arg 3 of `pam_get_data' from incompatible pointer type
*** Error code 1

pam_winbind missed #include, which describes PATH_MAX (sys/syslimits.h). There is a patch to fix:
--- pam_winbind.h.bak   Thu May 18 14:07:15 2006
+++ pam_winbind.h       Thu May 18 14:07:15 2006
@@ -18,6 +18,7 @@
 #include <fcntl.h>
 #include <errno.h>
 #include <time.h>
+#include <sys/syslimits.h>
 
 #include <config.h>
Comment 1 Jeremy Allison 2006-05-22 19:12:20 UTC
Not all systems have sys/syslimits.h - does this work if it's 
put after the #include config.h and protected with
#ifdef HAVE_SYS_SYSLIMITS_H ?
Jeremy.
Comment 2 Rashid N. Achilov 2006-05-22 21:58:45 UTC
(In reply to comment #1)
> Not all systems have sys/syslimits.h - does this work if it's 
> put after the #include config.h and protected with
> #ifdef HAVE_SYS_SYSLIMITS_H ?

Hasn't check, but I think it should work. Of course, syslimits.h should be checked by configure.

Comment 3 Gerald (Jerry) Carter 2006-06-22 14:58:51 UTC
Still an issue ?  Please retest 3.0.23rc3 and reopen if necessary.
Comment 4 Gerald (Jerry) Carter 2006-08-04 12:03:18 UTC
closing.  no response.