Bug 3725 - Configure check for PICFLAGS fails
Summary: Configure check for PICFLAGS fails
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.0.23
Hardware: Other All
: P3 normal
Target Milestone: none
Assignee: Tim Potter
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-25 19:18 UTC by Timur Bakeyev
Modified: 2006-04-26 14:15 UTC (History)
0 users

See Also:

Attachments
Fix (426 bytes, patch)
2006-04-25 19:19 UTC, Timur Bakeyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timur Bakeyev 2006-04-25 19:18:44 UTC 
There is a small bug in a chek of PICFLAGS in configure. It's not taken into account that value of a variable could have several words, space separated. So, the following message is produced during the run of configure:

checking whether to use pam_smbpass... yes
test: x-fPIC: unexpected operator
checking for library containing crypt... -lcrypt

The fix is easy - just take variavle in quotes. Patch is attached. Also, it's possible to use:

if test -z $PICFLAGS ; then

construction instead. Maybe, it's better option.
Comment 1 Timur Bakeyev 2006-04-25 19:19:19 UTC 
Created attachment 1875 [details]
Fix
Comment 2 Tim Potter 2006-04-26 14:15:42 UTC 
Fixed - thanks!  There was another unescaped usage of $PICFLAGS in the configure instructions for smbwrapper.