Bug 3596 - rsync fails to retouch S_IWUSR when transferring a single empty directory
rsync fails to retouch S_IWUSR when transferring a single empty directory
Status: CLOSED FIXED
Product: rsync
Classification: Unclassified
Component: core
2.6.7
All All
: P3 normal
: ---
Assigned To: Wayne Davison
Rsync QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-03-09 22:37 UTC by Matt McCutchen
Modified: 2006-03-12 02:56 UTC (History)
0 users

See Also:


Attachments
Fixes the bug by running directory retouching even when there's a local name (1.00 KB, patch)
2006-03-09 22:49 UTC, Matt McCutchen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt McCutchen 2006-03-09 22:37:03 UTC
Run the following in an empty directory:
    mkdir test
    chmod 400 test
    rsync --dirs --perms test test2
test2 incorrectly ends up with 600 permissions because rsync sees that a local name is in use and assumes the directory retouching phase is unnecessary.  rsync should run the phase anyway and deal with a local name if there is one.
Comment 1 Matt McCutchen 2006-03-09 22:49:33 UTC
Created attachment 1781 [details]
Fixes the bug by running directory retouching even when there's a local name
Comment 2 Wayne Davison 2006-03-10 10:00:20 UTC
I decided to fix this by preventing a local_name transfer from tweaking the directory's permissions in the first place (since there's no need for it to have write permission if nothing is going inside it).

The fix is now in CVS.  Thanks!