Bug 3581 - off_t undefined in talloc.h
Summary: off_t undefined in talloc.h
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PPC Mac OS X
: P3 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Andrew Bartlett
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-03 17:09 UTC by Steffond Jones
Modified: 2006-07-26 08:19 UTC (History)
1 user (show)

See Also:

Attachments
patch for Darwin (Mac OS X) (379 bytes, patch)
2006-03-03 17:11 UTC, Steffond Jones 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffond Jones 2006-03-03 17:09:46 UTC 
buildfarm failure in svn://svnanon.samba.org/samba/branches/SAMBA_4_0/source/lib/talloc

In file included from testsuite.c:40:
talloc.h:115: error: parse error before "talloc_total_size"
talloc.h:115: warning: type defaults to 'int' in declaration of 'talloc_total_size'
talloc.h:115: warning: data definition has no type or storage class
talloc.h:116: error: parse error before "talloc_total_blocks"
talloc.h:116: warning: type defaults to 'int' in declaration of 'talloc_total_blocks'
talloc.h:116: warning: data definition has no type or storage class
testsuite.c:339: warning: unused parameter 'ptr'

patch enclosed
Comment 1 Steffond Jones 2006-03-03 17:11:02 UTC 
Created attachment 1774 [details]
patch for Darwin (Mac OS X)
Comment 2 Jelmer Vernooij 2006-03-10 08:23:05 UTC 
I'm not sure what the best way would be to fix this. Can we depend on sys/types.h being installed on all systems talloc can build on? If we can't, then we would have to switch to autogenerating talloc.h (which I think would be a very bad idea) or simply getting the user to include sys/types.h before talloc.h.
Comment 3 Stefan Metzmacher 2006-07-26 08:19:49 UTC 
off_t is removed from talloc now