Bug 345 - coredump in smbclient Tar Extract mode
coredump in smbclient Tar Extract mode
Status: CLOSED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: smbclient
3.0.0preX
All Linux
: P3 normal
: 3.0.0rc2
Assigned To: Jeremy Allison
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2003-08-25 03:46 UTC by Waider
Modified: 2005-11-14 09:26 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Waider 2003-08-25 03:46:02 UTC
[root@workst1 home]# smbclient -E -d 0 -A /root/cred //workst1/print\$ -t
drivers.tar -c 'tarmode full' -Tx
Segmentation fault (core dumped)

Backtrace:
#0  0x08065ae7 in tar_parseargs (argc=12, argv=0xbffffaf4, 
    Optarg=0x8100c70 "x", Optind=12) at client/clitar.c:1778
1778                    if (!strcmp(argv[Optind], "-")) {
(gdb) where
#0  0x08065ae7 in tar_parseargs (argc=12, argv=0xbffffaf4, 
    Optarg=0x8100c70 "x", Optind=12) at client/clitar.c:1778
#1  0x08061142 in main (argc=12, argv=0xbffffaf4) at client/client.c:2869
#2  0x42017589 in __libc_start_main () from /lib/i686/libc.so.6
Comment 1 Waider 2003-08-25 03:53:39 UTC
Moving the tarfile to the end of the command line appears to fix the problem.
Comment 2 Gerald (Jerry) Carter 2003-08-25 21:51:46 UTC
Jeremy,  Can you take a look at these when you get a chance? Thanks.
Comment 3 Tim Potter 2003-08-27 00:39:14 UTC
According to the manual page the -t option sets up smbclient for some possibly
broken character conversion code.

Yuck - the smbclient tar code is just awful.  )-:

I've checked in a fix to not crash when you don't specify a tarfile argument to -T.
Comment 4 Tim Potter 2003-08-27 00:39:36 UTC
Add me as cc
Comment 5 Gerald (Jerry) Carter 2005-02-07 09:05:42 UTC
originally reported against one of the 3.0.0rc[1-4] releases.
Cleaning up non-production versions.
Comment 6 Gerald (Jerry) Carter 2005-08-24 10:17:03 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.
Comment 7 Gerald (Jerry) Carter 2005-11-14 09:26:47 UTC
database cleanup