Bug 3419 - vfs module "full_audit" reported as "broken"
Summary: vfs module "full_audit" reported as "broken"
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: File Services (show other bugs)
Version: 3.0.21a
Hardware: x86 Linux
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL: http://bugs.debian.org/348419
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-18 00:57 UTC by Christian Perrier (dead mail address)
Modified: 2006-01-18 17:35 UTC (History)
0 users

See Also:

Attachments
Proposed patch (1.27 KB, patch)
2006-01-18 00:58 UTC, Christian Perrier (dead mail address) 		no flags Details
Patch I've applied. (3.98 KB, patch)
2006-01-18 17:33 UTC, Jeremy Allison 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Perrier (dead mail address) 2006-01-18 00:57:47 UTC 
The whole bug log is available at http://bugs.debian.org/348419. here's what our user is saying:

The vfs module "full_audit" is broken, somehow the parameter bitmap
gets freed after the client disconnects from the share (but not the
server). In result, the modules logs everything, filling up /var and
using lots of cpu for smbd and syslog processes.

The patch has been tested and works fine, it's an immediate fix but
maybe not the right way to do it.
It would be appreciated to have the patch in debian while it is
submitted upstream.
Comment 1 Christian Perrier (dead mail address) 2006-01-18 00:58:11 UTC 
Created attachment 1697 [details]
Proposed patch
Comment 2 Jeremy Allison 2006-01-18 13:52:37 UTC 
The underlying problem is that the success and failure bitmasks are *statics*. They'll be deleted on every disconnect on any share. They should be attached to the connection struct as a private data pointer. I'll look into fixing this properly.
Jeremy.
Comment 3 Jeremy Allison 2006-01-18 17:33:06 UTC 
Created attachment 1701 [details]
Patch I've applied.
Comment 4 Jeremy Allison 2006-01-18 17:35:30 UTC 
Should be fixed correctly in current SVN. Target for 3.0.21b.
Jeremy.