When trying to restore a file that is 4GB in size from a tarball,
the restore fails with 2gb (exactly) of the file being written to the
host.

command: smbclient //<target ip>/<share> "<password>" -U <user> -Tx <tarball>

error reported:
--
Error writing remote file
Abandoning restore
--

This was tried with the following versions:
Version 3.0.3-5
Version 3.0.20b

Using smbclient and a "put"ting the 4gb file from the tarball works fine.

--

Having had a look at client/clitar.c:

I'm curious if pos,dsize (and possibly bpos) variables be 
off_t's and not ints ?

As ints there is the possibility that they are restricting 
the maximum file size that can be restored from a tarball to 2gb.

I've tried converting them to off_t's, but it seems a little more
complicated than that as these changes result in some 9728 bytes 
extra (total file size of being written to the file 4177683968 bytes),
and a error returned regarding the tarfile.

Extracting the file from the tarball using tar extracts the file successfully.

----
Changes trialed in client/clitar.c - get_file() function:
----
static int get_file(file_info2 finfo)
{
/*      int fnum = -1, pos = 0, dsize = 0, bpos = 0; existing variable
declarations */
/* new declarations */
        int fnum = -1;
        off_t pos = 0, dsize = 0, bpos = 0;

        SMB_BIG_UINT rsize = 0;

        DEBUG(5, ("get_file: file: %s, size %.0f\n", finfo.name,
(double)finfo.size));

        if (ensurepath(finfo.name) &&
                        (fnum=cli_open(cli, finfo.name, O_RDWR|O_CREAT|O_TRUNC,
DENY_NONE)) == -1) {
                DEBUG(0, ("abandoning restore\n"));
                return(False);
        }

        /* read the blocks from the tar file and write to the remote file */

        rsize = finfo.size;  /* This is how much to write */

        while (rsize > 0) {

                /* We can only write up to the end of the buffer */
                dsize = MIN(tbufsiz - (buffer_p - tarbuf) - bpos, 65520); /*
Calculate the size to write */
                dsize = MIN(dsize, rsize);  /* Should be only what is left */
                DEBUG(5, ("writing %i bytes, bpos = %i ...\n", dsize, bpos));

                if (cli_write(cli, fnum, 0, buffer_p + bpos, pos, dsize) !=
dsize) {
                        DEBUG(0, ("Error writing remote file\n"));


-----
cli_write protocol definition from include/proto.h
-----
size_t cli_write(struct cli_state *cli,
                 int fnum, uint16 write_mode,
                 const char *buf, off_t offset, size_t size);

-----
Initially these seemed like they fitted bug #563, but having thought about it more, it seems like they don't. The entries that I've added there could be removed.