Bug 3313 - Pidl should generate Ethereal dissectors that display bitmaps in hex
Summary: Pidl should generate Ethereal dissectors that display bitmaps in hex
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All All
: P3 normal (vote)
Target Milestone: ---
Assignee: Jelmer Vernooij
QA Contact: Andrew Bartlett
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-10 15:33 UTC by Guy Harris
Modified: 2005-12-11 07:44 UTC (History)
0 users

See Also:

Attachments
Patch to make bitmaps display in hex (618 bytes, patch)
2005-12-10 15:34 UTC, Guy Harris 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guy Harris 2005-12-10 15:33:31 UTC 
The Bitmap routine in lib/Parse/Pidl/Ethereal/NDR.pm in Pidl generates fields as BASE_DEC; bitmaps are typically displayed in hex in Ethereal, so it should generate BASE_HEX instead.
Comment 1 Guy Harris 2005-12-10 15:34:18 UTC 
Created attachment 1610 [details]
Patch to make bitmaps display in hex
Comment 2 Jelmer Vernooij 2005-12-11 07:44:33 UTC 
Applied. Thanks!