Bug 3141 - python bindings: samba_libs variable parsing patch
Summary: python bindings: samba_libs variable parsing patch
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: python (show other bugs)
Version: 3.0.20a
Hardware: All Linux
: P3 normal
Target Milestone: none
Assignee: Tim Potter
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-06 03:33 UTC by Christian Andreetta (dead mail address)
Modified: 2005-10-06 20:49 UTC (History)
0 users

See Also:

Attachments
source/python/setup.py patch: samba_libs parsing (1.25 KB, patch)
2005-10-06 03:36 UTC, Christian Andreetta (dead mail address) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Andreetta (dead mail address) 2005-10-06 03:33:57 UTC 
I'm attaching a patch to source/python/setup.py that permits to parse a larger
amount of linker flags.
Trivial cosmetic note: with the if...else contruct, it could be possible to
remove the 'continue' instruction at every check. I leave it to you, since I
don't now if further instructions are needed in the for loop.
Comment 1 Christian Andreetta (dead mail address) 2005-10-06 03:36:31 UTC 
Created attachment 1491 [details]
source/python/setup.py patch: samba_libs parsing
Comment 2 Tim Potter 2005-10-06 16:53:13 UTC 
Yes your comments about the if/else stuff are well taken.  It does look pretty
awful.
Comment 3 Tim Potter 2005-10-06 20:49:21 UTC 
OK I've applied your patch - thanks!  I ditched the continue bit.

However the extensions haven't been built in a while so are broken after
Jeremy's rpc client rewrite.  )-: