Bug 3111 - pgsql backend: pdbedit -L segfaults(bug in pdb_pgsql.c)
Summary: pgsql backend: pdbedit -L segfaults(bug in pdb_pgsql.c)
Status: RESOLVED WONTFIX
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: pdb_sql (show other bugs)
Version: 3.0.20
Hardware: All All
: P3 normal
Target Milestone: none
Assignee: pdb_sql maintainers mail alias
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-18 15:15 UTC by Uli M
Modified: 2006-02-10 08:42 UTC (History)
1 user (show)

See Also:

Attachments
Removes the if clause in pdb_pgsql.c/setsampwent() that frees the SELECT result before it's ever used (296 bytes, patch)
2005-09-18 15:18 UTC, Uli M 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uli M 2005-09-18 15:15:21 UTC 
The result of the select query is freed in setsampwent before it can be read by
subsequent calls to getsampwent.
The patch corrects that. Since the structure is still freed in the final call to
endsampwent all should be fine.
Comment 1 Uli M 2005-09-18 15:18:49 UTC 
Created attachment 1453 [details]
Removes the if clause in pdb_pgsql.c/setsampwent() that frees the SELECT result before it's ever used
Comment 2 Florian Effenberger 2005-12-23 06:43:52 UTC 
Maybe this new bug is of interest for those on the Cc list:

https://bugzilla.samba.org/show_bug.cgi?id=3351
Comment 3 Gerald (Jerry) Carter (dead mail address) 2006-02-10 08:42:07 UTC 
See bug 3375.  If someone wants to maintain these modules outside
the Samba source tree, that is fine.  But the source has been removed
from the upcoming 3.0.22 release.