Bug 3079 - [Patch] Clean up warnings
Summary: [Patch] Clean up warnings
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Upgrade (show other bugs)
Version: 3.0.20
Hardware: x86 Linux
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-09 08:36 UTC by Jay Fenlason - please log in and update your mail address here and let us enable Bugmails to you again, Jay
Modified: 2005-09-28 05:08 UTC (History)
0 users

See Also:

Attachments
Quiet some compiler warnings (43 bytes, patch)
2005-09-09 08:39 UTC, Jay Fenlason - please log in and update your mail address here and let us enable Bugmails to you again, Jay 		no flags Details
Attaching the patch using a different browser. (20.61 KB, patch)
2005-09-09 08:42 UTC, Jay Fenlason - please log in and update your mail address here and let us enable Bugmails to you again, Jay 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Fenlason - please log in and update your mail address here and let us enable Bugmails to you again, Jay 2005-09-09 08:36:13 UTC 
The attached patch cleans up a number of compiler warnings in the 3.0.20 
release.
Comment 1 Jay Fenlason - please log in and update your mail address here and let us enable Bugmails to you again, Jay 2005-09-09 08:39:01 UTC 
Created attachment 1427 [details]
Quiet some compiler warnings

Since this is part of a larger patch, I'm going to do another compile cycle to
make sure I didn't break anything.

Also, the parts that assign a default value to error return codes should be
checked for saneness.
Comment 2 Jay Fenlason - please log in and update your mail address here and let us enable Bugmails to you again, Jay 2005-09-09 08:42:50 UTC 
Created attachment 1428 [details]
Attaching the patch using a different browser.

Konqueror on RHEL-3 sometimes refuses to actually attach patches to bugs,
attaching the pathname of the patch instead.  I'm trying again with Mozilla
Comment 3 Jay Fenlason - please log in and update your mail address here and let us enable Bugmails to you again, Jay 2005-09-09 08:49:08 UTC 
Note that this doesn't by any means clean up all the warnings, just the ones I 
got to before I got tired of wading through them, and doesn't include the ones 
where I consider the patch worse than the warning.
Comment 4 Jeremy Allison 2005-09-09 08:56:10 UTC 
Looks good, but please don't apply before my rpc rewrite is merged.
Thanks,
Jeremy.
Comment 5 Gerald (Jerry) Carter (dead mail address) 2005-09-28 05:08:19 UTC 
Jay, this looks good.  Parts of the patch are no longer applicable
though, but what is will be in 3.0.21.