Bug 2966 - smbd/sesssetup.c: "unsigned char*" incompatible with "const char *"
smbd/sesssetup.c: "unsigned char*" incompatible with "const char *"
Status: RESOLVED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: Build environment
3.0.20
SGI IRIX
: P3 normal
: none
Assigned To: Tim Potter
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-09 07:40 UTC by Jason Mader
Modified: 2006-06-14 06:10 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader 2005-08-09 07:40:38 UTC
cc-1164 cc: WARNING File = smbd/sesssetup.c, Line = 663
  Argument of type "unsigned char *" is incompatible with parameter of type
          "const char *".

        if (strncmp(blob1.data, "NTLMSSP", 7) == 0) {
                    ^
Comment 1 Jason Mader 2005-08-09 07:48:37 UTC
blob1.data is of type "uint8 *"

In a case like this, wouldn't it be better to use bcmp()?
Comment 2 Tim Potter 2005-08-09 08:01:01 UTC
Yeah using strcmp() is just wrong.  We would probably use memcmp() though.
Comment 3 Jason Mader 2006-06-14 06:10:00 UTC
Compiler warning is not in 3.0.23rc2