Bug 2939 - rpc_server/srv_svcctl_nt.c: num_int_services
rpc_server/srv_svcctl_nt.c: num_int_services
Status: CLOSED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: Build environment
3.0.20
SGI IRIX
: P3 minor
: none
Assigned To: Tim Potter
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-01 11:53 UTC by Jason Mader
Modified: 2005-08-24 10:21 UTC (History)
0 users

See Also:


Attachments
Level 10 log file (238.71 KB, application/octet-stream)
2005-08-01 14:54 UTC, Jason Mader
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader 2005-08-01 11:53:14 UTC
cc-1164 cc: WARNING File = rpc_server/srv_svcctl_nt.c, Line = 455
  Argument of type "unsigned int *" is incompatible with parameter of type
          "int *".

          result = enum_internal_services(p->mem_ctx, &services, 0, &num_int_services);
                                                                    ^
Comment 1 Jason Mader 2005-08-01 12:02:48 UTC
enum_internal_services() might use "uint32 *" for this argument type instead, and in the function 
enum_internal_services() the variable num_services should be defined as "uint32".

Also, note on Line 446:
    num_int_services = 0;

this statement is already done at variable instantiation, and from the comments it looks like two additional 
function calls are planned.  This statement could be removed.
Comment 2 Tim Potter 2005-08-01 12:59:22 UTC
Fixed - thanks!
Comment 3 Jason Mader 2005-08-01 14:54:27 UTC
Created attachment 1348 [details]
Level 10 log file

Samba 3.0.13
Comment 4 Gerald (Jerry) Carter 2005-08-24 10:21:03 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.