Bug 2872 - error in ntlmssp_set_workstation()
Summary: error in ntlmssp_set_workstation()
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: libsmbclient (show other bugs)
Version: 3.0.14a
Hardware: All All
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-13 06:53 UTC by Chris Ross
Modified: 2005-08-24 10:25 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Ross 2005-07-13 06:53:55 UTC 
I don't know how long this bug has been here, but it looks like
ntlmssp_set_workstation() was created by duplicating ntlmssp_set_domain().
The talloc call is made, but the ntlmssp_state->domain variable is checked
afterwards, instead of the ntlmssp_state->workstation that is what the talloc is
assigned to.
Oops.  :-)
Easy fix, line 185 of libsmb/ntlmssp.c as of 3.0.14a.
Comment 1 Gerald (Jerry) Carter (dead mail address) 2005-07-14 06:20:43 UTC 
got it thanks.
Comment 2 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:25:25 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.