Bug 2685 - CUPS (and any other) printing errors ignored
Summary: CUPS (and any other) printing errors ignored
Status: RESOLVED LATER
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Printing (show other bugs)
Version: 3.0.20
Hardware: All Linux
: P3 normal
Target Milestone: none
Assignee: Gerald (Jerry) Carter (dead mail address)
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-06 00:45 UTC by Andrew Bartlett
Modified: 2006-04-08 07:43 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2005-05-06 00:45:24 UTC 
In print_cups.c:cups_job_submit() we never set the error return, even if the job
failed to submit.

Even if we were to set the BOOL error code, the code in printing/printing.c
ignores the propogated errors.

This bites us at Hawker, where our bizarre setup can cause printing to 'invalid'
printers, but the same would happen if CUPS were just down, as far as I can see.

The whole stack should propogate valid NTSTATUS or WERROR codes
Comment 1 Gerald (Jerry) Carter (dead mail address) 2005-05-09 05:56:12 UTC 
don't suppose you have a patch ?
Comment 2 Gerald (Jerry) Carter (dead mail address) 2005-09-27 09:30:55 UTC 
requires a fairly large redesign not on the radar right now.
Comment 3 Gerald (Jerry) Carter (dead mail address) 2006-04-08 07:43:44 UTC 
Cleaning up versions.  There was no 3.0.15 so leaving it in bugzilla 
is causing some confusion.  Moving these nuder 3.0.20.
Originally files against 3.0.15preX.