Bug 2551 - Win98 fails to run FOXPRO DOS apps on 3.0.12 and upper.
Summary: Win98 fails to run FOXPRO DOS apps on 3.0.12 and upper.
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: File Services (show other bugs)
Version: 3.0.12
Hardware: x86 FreeBSD
: P3 major
Target Milestone: none
Assignee: Jeremy Allison
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-27 23:44 UTC by Alex Masterov
Modified: 2005-08-24 10:21 UTC (History)
0 users

See Also:

Attachments
Ethereal sniff attempting to run FoxPro from 3.0.14pre1-SVN-build-6092 (7.62 KB, application/octet-stream)
2005-03-27 23:53 UTC, Alex Masterov 		no flags Details
Ethereal sniff attempting to run FoxPro from Samba 3.0.10 (94.56 KB, application/octet-stream)
2005-03-28 00:06 UTC, Alex Masterov 		no flags Details
Proposed patch. (2.78 KB, patch)
2005-03-28 17:32 UTC, Jeremy Allison 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Masterov 2005-03-27 23:44:43 UTC 
When attempting to run any foxpro 2.6 for DOS application (or foxpro itself)
from the Samba 3.0.12 and upper shared drive the error "Cannot locate the
desired version of FoxPro" occuried. Client is Windows 98.
This bug present in 3.0.14pre1-SVN-build-6092. 
Making all files on UNIX side UPPERCASE elliminates this error, i.e. FoxPro apps
start normaly.
Comment 1 Alex Masterov 2005-03-27 23:53:09 UTC 
Created attachment 1123 [details]
Ethereal sniff attempting to run FoxPro from 3.0.14pre1-SVN-build-6092

Samba 3.0.14pre1-SVN-build-6092, files on UNIX side are lowercase, client is
Windows 98 SE
Result: "Cannot locate desired version of FoxPro"
Comment 2 Alex Masterov 2005-03-28 00:06:25 UTC 
Created attachment 1124 [details]
Ethereal sniff attempting to run FoxPro from Samba 3.0.10

Samba 3.0.10, files on UNIX side are lowercase, client is Windows 98 SE.

Result: successful run of FoxPro
Comment 3 Jeremy Allison 2005-03-28 10:15:30 UTC 
Ok, I'll take a look at this and try and get a fix asap.
Thanks,
Jeremy.
Comment 4 Jeremy Allison 2005-03-28 14:21:56 UTC 
Ok, the trace you're showing me show that the SMBsearch reply is still
being done in lowercase. The changed code in lib/util.c is now :

        /* We only uppercase if the protocol is downrev.
           Strange, but verified on W2K3. Needed for OS/2. JRA. */
        push_ascii(buf+30,fname,12,Protocol < PROTOCOL_NT1 ? STR_UPPER : 0);

So this means the client must be negotiating NT1 protocol. Can you send me
the trace showing the negprot ? I thought the code we had here was correct as if
I do SMBsearch requests against a W2K3 server with NT1 protocol it doesn't
uppercase the names, but I'll re-check. I can easily fix this by making the
"STR_UPPER" flag forced, but I'd prefer to understand the problem.

Jeremy.
Comment 5 Jeremy Allison 2005-03-28 17:32:14 UTC 
Created attachment 1125 [details]
Proposed patch.
Comment 6 Jeremy Allison 2005-03-28 17:34:38 UTC 
Ok, I think I have this - it's the incoming FLAGS2 bit
"FLAGS2_LONG_PATH_COMPONENTS" that determines if the reply is uppercase - not
the protocol level at all. Make the server comply with this. Please test this,
I've checked it into SVN. I think it will fix the bug.
Jeremy.
Comment 7 Alex Masterov 2005-03-28 19:41:37 UTC 
On Samba 3.0.14pre1-SVN-build-6106 FoxPro apps can be runned from Windows 98
successfully.
This bug seems to be fixed.
Thank you!
Comment 8 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:21:12 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.