cc-1164 cc: WARNING File = passdb/pdb_nds.c, Line = 798 Argument of type "unsigned char *" is incompatible with parameter of type "char *". if (pdb_nds_get_password(ldap_state->smbldap_state, dn, &pwd_len, clear_text_pw) == L\ DAP_SUCCESS) { ^ cc-1164 cc: WARNING File = passdb/pdb_nds.c, Line = 856 Argument of type "unsigned char *" is incompatible with parameter of type "const char *". rc = ldap_simple_bind_s(ld, dn, clear_text_pw); ^
Changing clear_text_pw to "char *" on line 760 is consistent with other pdb_ code, but has the side effect cc-1164 cc: WARNING File = passdb/pdb_nds.c, Line = 803 Argument of type "char *" is incompatible with parameter of type "unsigned char *". generate_random_buffer(clear_text_pw, 24); ^
My thought is that generate_random_buffer() should have arguments just like read(), as in the case there's a /dev/urandom it's just reading directly from urandom anyway. And in most invocations in Samba code the length argument is sizeof() also. void generate_random_buffer(void *out, size_t len)
lowering priority
Reassign IRIX bugs to me.
Created attachment 1372 [details] change parameter types on generate_random_buffer()
This was just fixed in Revision 9303 with the (unsigned char *) typecast on the argument to calls of generate_random_buffer(). However, I really still think there should be no typecast, and instead change the parameters on the generate_random_buffer function to "void *" and "size_t": void generate_random_buffer(void *out, size_t len); This isn't anything more than a glorified call to read() anyway, so it's parameters should be the same as read. It's consistent with other functions in lib/genrand.c.
This file no longer exists in 3.0.23rc3