Bug 2505 - libsmbclient: large file support fixes
Summary: libsmbclient: large file support fixes
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: libsmbclient (show other bugs)
Version: 3.0.12
Hardware: All Linux
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-21 13:19 UTC by Derrell Lipman
Modified: 2005-08-24 10:19 UTC (History)
0 users

See Also:

Attachments
patch to fix this bug (15.42 KB, patch)
2005-03-21 13:21 UTC, Derrell Lipman 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Derrell Lipman 2005-03-21 13:19:56 UTC 
Large file support (files >=4GB) was broken in libsmbclient due to size_t being
used as the type for passing file sizes and offsets.  size_t does not grow to 64
bits when -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 flags are used.  The
attached patch fixes this by using the internal type SMB_OFF_T in place of
size_t.  Note that there are numerous other uses of size_t which may or may not
be correct.  Those have not been verified.

This bug also supercedes #2447, as that patch is included herein.
Comment 1 Derrell Lipman 2005-03-21 13:21:09 UTC 
Created attachment 1059 [details]
patch to fix this bug
Comment 2 Gerald (Jerry) Carter (dead mail address) 2005-03-22 13:43:37 UTC 
applying patch to SAMBA_3_0 svn tree.
Comment 3 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:19:37 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.