Bug 2497 - rpc_parse/parse_spoolss.c, line 1242: unsigned int compared to zero
Summary: rpc_parse/parse_spoolss.c, line 1242: unsigned int compared to zero
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: libsmbclient (show other bugs)
Version: 3.0.12
Hardware: All All
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-19 11:43 UTC by Jason Mader (mail bounces back)
Modified: 2005-08-24 10:17 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader (mail bounces back) 2005-03-19 11:43:03 UTC 
Compiling rpc_parse/parse_spoolss.c with -KPIC
cc-1183 cc: WARNING File = rpc_parse/parse_spoolss.c, Line = 1242
  An unsigned integer is being compared to zero.

        if (version >= 0) { 
                    ^
Comment 1 Jason Mader (mail bounces back) 2005-03-19 11:43:31 UTC 
Since version is an unsigned int, it will always be greater than or equal to
zero, so couldn't this test be eliminated?
Comment 2 Gerald (Jerry) Carter (dead mail address) 2005-03-22 07:43:20 UTC 
actually version should be an int.
Comment 3 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:17:27 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.