Bug 2480 - lib/util_str.c: "return" expression type
Summary: lib/util_str.c: "return" expression type
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: libsmbclient (show other bugs)
Version: 3.0.11
Hardware: All All
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-18 10:37 UTC by Jason Mader (mail bounces back)
Modified: 2005-08-24 10:26 UTC (History)
0 users

See Also:

Attachments
add (char *) typecast to return (331 bytes, patch)
2005-03-18 10:42 UTC, Jason Mader (mail bounces back) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader (mail bounces back) 2005-03-18 10:37:50 UTC 
cc-1119 cc: WARNING File = lib/util_str.c, Line = 1337
  The "return" expression type differs from the function return type.

                return src;
                       ^
Comment 1 Jason Mader (mail bounces back) 2005-03-18 10:39:47 UTC 
        /* for correctness */
        if (!findstr[0]) {
                return (char *)src;
        }

Adding (char *) is consistent with the other return in the fucntion.
Comment 2 Jason Mader (mail bounces back) 2005-03-18 10:42:52 UTC 
Created attachment 1045 [details]
add (char *) typecast to return
Comment 3 Gerald (Jerry) Carter (dead mail address) 2005-03-22 08:16:46 UTC 
got it.
Comment 4 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:26:09 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.