Bug 2480 - lib/util_str.c: "return" expression type
lib/util_str.c: "return" expression type
Status: CLOSED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: libsmbclient
3.0.11
All All
: P3 normal
: none
Assigned To: Samba Bugzilla Account
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-18 10:37 UTC by Jason Mader
Modified: 2005-08-24 10:26 UTC (History)
0 users

See Also:


Attachments
add (char *) typecast to return (331 bytes, patch)
2005-03-18 10:42 UTC, Jason Mader
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader 2005-03-18 10:37:50 UTC
cc-1119 cc: WARNING File = lib/util_str.c, Line = 1337
  The "return" expression type differs from the function return type.

                return src;
                       ^
Comment 1 Jason Mader 2005-03-18 10:39:47 UTC
        /* for correctness */
        if (!findstr[0]) {
                return (char *)src;
        }

Adding (char *) is consistent with the other return in the fucntion.
Comment 2 Jason Mader 2005-03-18 10:42:52 UTC
Created attachment 1045 [details]
add (char *) typecast to return
Comment 3 Gerald (Jerry) Carter 2005-03-22 08:16:46 UTC
got it.
Comment 4 Gerald (Jerry) Carter 2005-08-24 10:26:09 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.