Bug 2367 - wins-hook fails to call 'delete'
Summary: wins-hook fails to call 'delete'
Status: NEW
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: nmbd (show other bugs)
Version: 3.0.11
Hardware: All Linux
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
Depends on:
Reported: 2005-02-21 07:12 UTC by Evert
Modified: 2009-04-04 08:02 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Evert 2005-02-21 07:12:17 UTC
in an attempt to create some sort of ddns with wins using the 'wins hook' i 
noticed that 'delete' is not always called when the wins-list is changed. i 
think that a wins_hook("delete", namerec, 0) should be called everytime a 
remove_name_from_namelist is done. it is done for the 'add' but not for 
the 'delete'. 
an example where the call is missing is in the 'wins_register_query_fail' 
function. and in nmbd_serverlistdb.c when nmbd is removing 'expired' entries 
in the list:

			DEBUG(3,("expire_names_on_subnet: Subnet %s - removing 
expired name %s\n",
				subrec->subnet_name, nmb_namestr(&namerec-
			remove_name_from_namelist( subrec, namerec );

wins_hook("delete, namerec, 0) should me called then as well...
Comment 1 Evert 2005-02-21 09:39:19 UTC
(In reply to comment #0)

it looks like it can be easily fixed by adding a 'wins_hook("delete", namerec, 
0);' in function 'void remove_name_from_namelist' in file