Bug 2357 - error when compiling rsync under Windows Services for Unix
Summary: error when compiling rsync under Windows Services for Unix
Status: CLOSED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 2.6.4
Hardware: All Windows XP
: P3 minor (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-17 11:07 UTC by The Happy Space Invader
Modified: 2005-04-01 11:25 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description The Happy Space Invader 2005-02-17 11:07:35 UTC 
Error: "undefined reference to `_makedev'" occurs when compiling under Windows
Services for Unix 3.5.

To remedy, simply edit flist.c and change every occurrence of 'makedev' to
'mkdev'.  Once you run make again, it compiles fine and runs on Windows with no
problems (so far).
Comment 1 The Happy Space Invader 2005-02-17 11:09:55 UTC 
What I meant to ask was, can this be automatically determined somehow so other
users of Windows Services for Unix don't have to hack flist.c like I did?
Comment 2 Wayne Davison 2005-02-17 18:04:33 UTC 
The CVS version has this code in rsync.h to try to deal with this:

#if !defined makedev && defined mkdev
#define makedev mkdev
#endif

So, under Windows Services for Unix, is mkdev not a define?  I suppose we could
change the #if to something like this:

#if !defined makedev && (defined mkdev || defined WIN32)

Does that work?  Any better ideas?
Comment 3 Wayne Davison 2005-02-25 17:04:06 UTC 
I put a fix for this into 2.6.4pre1, so I hope that this is now resolved.  If
not, reopen the bug.