Bug 2356 - smbclient -t <term code> no longer works
smbclient -t <term code> no longer works
Status: RESOLVED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: Client Tools
3.0.11
All All
: P3 trivial
: none
Assigned To: Samba Bugzilla Account
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-02-17 08:46 UTC by TAKAHASHI Motonobu
Modified: 2009-06-03 11:46 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description TAKAHASHI Motonobu 2005-02-17 08:46:14 UTC
smbclient -t <term code> can be speficied but is no longer used anywhere.
It's time to remove -t option both source and smbclient(1).
Also it remains in smbtortune and testparm.

monyo@maple:~/Work/Samba/samba-3.0.11/source$ grep term_code */*.[ch]
client/client.c:        pstring term_code;
client/client.c:        pstrcpy(term_code, KANJI);
client/client.c:        *term_code = 0;
client/client.c:                        pstrcpy(term_code, poptGetOptArg(pc));
include/rpc_misc.h:enum unistr2_term_codes { UNI_FLAGS_NONE = 0, UNI_STR_TERMI
NATE = 1, UNI_MAXLEN_TERMINATE = 2, UNI_BROKEN_NON_NULL = 3 };
rpc_parse/parse_misc.c:void init_unistr2(UNISTR2 *str, const char *buf, enum u
nistr2_term_codes flags)
torture/rpctorture.c:   pstring term_code;
torture/rpctorture.c:   pstrcpy(term_code, KANJI);
torture/rpctorture.c:   *term_code = 0;
torture/rpctorture.c:                           pstrcpy(term_code, optarg);
utils/testparm.c:       static const char *term_code = "";
utils/testparm.c:               {"encoding", 't', POPT_ARG_STRING, &term_code,
 0, "Print parameters with encoding"},
Comment 1 Gerald (Jerry) Carter 2006-04-14 15:01:54 UTC
I'm pretty sure this has been removed now.
Comment 2 TAKAHASHI Motonobu 2009-06-03 11:27:53 UTC
Still remains at Samba 3.3.4.
Comment 3 Jeremy Allison 2009-06-03 11:46:04 UTC
I've removed the code and docs in master. Probably won't make 3.4 but will be in all future releases.
Thanks for bugging me about this !
Jeremy.