The Samba-Bugzilla – Bug 2270
Potential mem leak in Samba print_cups code
Last modified: 2005-08-24 10:26:24 UTC
source/printing/print_cups.c doesn't free allocated memory with ippDelete() and
cupsLangFree(). This might lead to a memory leak as the functions from
print_cups.c are called regular at least by check_reload().
Created attachment 904 [details]
Use ippDelete() and cupsLangFree() before return.
In the patch I've also removed some superfluous ippNew() and cupsLangDefault()
Patch needs more testing. ;)
Created attachment 905 [details]
Try this one instead :-).
Gahhh!!!! cupDoRequest() calls ippDelete(request) so
the segv was caused by calling ippDelete() on the same
pointer in our code.
That's just *insane*! Unless its a documented feature
of cups I guess.
jra's patched has been tested and cleaned up where necessary.
Not documented in the CUPS book or the CUPS Software Programmers Manual.
Found the same problem while testing Jeremy's patch.
I suggest to leave a comment about this feature of cupsDoFileRequest() in
originally reported against 3.0.11pre1. Moving back to version to 3.0.10
to remove preX and rcX versions.
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.