Bug 2210 - Some NT_STATUS_* errors don't have mapped PAM errors
Some NT_STATUS_* errors don't have mapped PAM errors
Status: REOPENED
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Winbind
unspecified
x86 Linux
: P3 normal
: ---
Assigned To: Björn Jacke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-05 06:58 UTC by Narayana Pattipati
Modified: 2016-12-08 17:31 UTC (History)
1 user (show)

See Also:


Attachments
Patch to map some NT_STATUS_* errors to PAM errors (1.52 KB, patch)
2005-01-05 07:22 UTC, Narayana Pattipati
no flags Details
patch to add/fix error code mappings (2.26 KB, patch)
2016-12-08 17:31 UTC, Björn Jacke
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Narayana Pattipati 2005-01-05 06:58:17 UTC
Error messages like NT_STATUS_ACCOUNT_DISABLED, NT_STATUS_PASSWORD_RESTRICTION
does not have mapped PAM errors. So, when an application receives them, the PAM 
error will be "4", which is PAM_SYS_ERROR. 

So, the end user will not know what went wrong even though pam_winbind returns 
errors like "account disabled", "password restriction" etc. 

These errors should be mapped to known PAM errors, so that applications can
interpret them in a better way and convey the same to end user.
Comment 1 Narayana Pattipati 2005-01-05 07:22:58 UTC
Created attachment 877 [details]
Patch to map some NT_STATUS_* errors to PAM errors
Comment 2 Narayana Pattipati 2005-01-05 07:23:53 UTC
The patch attached above was discussed in samba-technical mailing list @
http://lists.samba.org/archive/samba-technical/2004-December/038398.html
Comment 3 Gerald (Jerry) Carter 2005-03-21 19:42:39 UTC
moving back to 3.0
Comment 4 Andrew Bartlett 2016-08-01 10:13:37 UTC
This looks like it has been fixed in the meantime.  It should be fixed in all current versions.
Comment 5 Björn Jacke 2016-12-08 17:31:16 UTC
Created attachment 12751 [details]
patch to add/fix error code mappings

I don't see where this should have been fixed.

Attached patch fixes this for current master.