The Samba-Bugzilla – Bug 221
multibyte user/computer names make nmbd crash
Last modified: 2005-08-24 10:18:33 UTC
See the thread of
Created attachment 49 [details]
prevents nmbd crash
The "prevents nmbd crash" patch written by MORIYAMA Masayuki
<email@example.com> also prevents nmbd crash,
but we cannot see Japanese computer name and comments on the browselist.
In browse.dat the computer name and comments are correctly written
in Japanese (CP932 encoded).
moving to extended character component
Accept this bug.
I found a problem that multibyte comments and computername on
browselist are not displayed from Windows clients.
This is because the following coding at smbd/lanman.c:1123
len += CopyAndAdvance(&p2,service->comment,&l2);
For comments field, there are 2 problems:
one is the CopyAndAdvance() breaks byte order.
Another is that in browse.dat, the codeset is 'as is (same as dos
charset)', but in CopyAndAdvance(), push_ascii(), which assumes input
strings are encoded with unix charset, is used. So if 'dos charset'
and 'unix charset' is different, the push_ascii() cannnot work well.
(And dos charset must be set correctly.)
To fix the problem, determine browse.dat is written with 'as is' and
modify the lanman.c or determine browse.dat is written with 'unix
charset' and modify the codes of nmbd.
should be fixed in latest SAMBA_3_0 cvs tree
(to be included in 3.0.0rc2). Please retest
I'm marking this as fixed in hopes that all of the mutibyte
character set work that was done for RC2 does resolve the
problem. If not, please reopen the bug
originally reported against 3.0.0beta2. CLeaning out
non-production release versions.
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.