Bug 2177 - patch to include to main tree
patch to include to main tree
Status: RESOLVED WONTFIX
Product: Samba 3.0
Classification: Unclassified
Component: Packaging
3.0.10
All FreeBSD
: P3 normal
: none
Assigned To: Gerald (Jerry) Carter
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-12-21 04:39 UTC by Ilia Chipitsine
Modified: 2005-02-03 07:17 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ilia Chipitsine 2004-12-21 04:39:33 UTC
that patch is included in FreeBSD's Ports collection, but I guess it would be
better to have in main source tree for two reasons:

1) few people do not not know how to install soft on FreeBSD and install
directly from sources

2) port's maintainers will not have to patch source in subsequent releases


--- include/local.h.orig        Tue Dec 21 16:25:36 2004
+++ include/local.h     Tue Dec 21 16:30:22 2004
@@ -170,10 +170,19 @@
  * Default passwd chat script.
  */

-#define DEFAULT_PASSWD_CHAT "*new*password* %n\\n *new*password* %n\\n *changed*"
+#if defined(__FreeBSD__)
+
+#define DEFAULT_PASSWD_CHAT "*\\n*ew\\spassword* %n\\n *ew\\spassword* %n\\n
*updating\\sthe\\sdatabase...\\npasswd:\\sdone\\n"
+/* Minimum length of allowed password when changing UNIX password. */
+#define MINPASSWDLENGTH 6

+#else
+
+#define DEFAULT_PASSWD_CHAT "*new*password* %n\\n *new*password* %n\\n *changed*"
 /* Minimum length of allowed password when changing UNIX password. */
 #define MINPASSWDLENGTH 5
+
+#endif /*!__FreeBSD__ */

 /* maximum ID number used for session control. This cannot be larger
    than 62*62 for the current code */
Comment 1 Gerald (Jerry) Carter 2005-02-03 07:17:17 UTC
I'm not including this for a couple of reasons.
(a) it will bit rot as things change on FreeBSD and 
    we don't know about them.
(b) a better solution is to define the password chat 
    in smb.conf
If people decide to install from source rather than
using a maintainer's package, then they should be willing 
to address the differences themselves.

Moving on....