Bug 2154 - [patch] expansion of '&' in struct passwd.pw_gecos
Summary: [patch] expansion of '&' in struct passwd.pw_gecos
Status: RESOLVED LATER
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: User/Group Accounts (show other bugs)
Version: 3.0.9
Hardware: All NetBSD
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-13 16:16 UTC by Luke Mewburn
Modified: 2006-04-14 14:54 UTC (History)
0 users

See Also:

Attachments
expand-gecos.patch (4.77 KB, patch)
2004-12-13 16:18 UTC, Luke Mewburn 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Mewburn 2004-12-13 16:16:32 UTC 
Samba doesn't support expanding occurrences of '&' in the pw_gecos field into
the capitalized pw_name. This pw_gecos feature is supported on BSD systems and
Solaris:
  Solaris passwd(4):  http://docs.sun.com/app/docs/doc/817-0716/6mggehbti?a=view
  NetBSD passwd(5):   http://netbsd.gw.com/cgi-bin/man-cgi?passwd+5+NetBSD-current

I raised this on samba-technical, without much response.  So I decided to
implement this in a 'clean and configurable' manner.  I implemented a new
smb.conf(5) boolean:
   passwd expand gecos = <boolean>
If that is 'yes', expand & in pw_gecos at the appropriate locations.

[i'll attach a patch].
Comment 1 Luke Mewburn 2004-12-13 16:18:44 UTC 
Created attachment 842 [details]
expand-gecos.patch

I haven't provided a documentation patch because that's autogenerated from
sources I don't currently have checked out.  If the functionality is accepted I
can help with wording of an smb.conf(5) entry for 'passwd expand gecos'.
Comment 2 Gerald (Jerry) Carter (dead mail address) 2006-04-14 14:54:04 UTC 
I don't really want a new parameter and there has not been 
any additional requests for this feature.