Bug 2113 - rpc_parse/parse_lsa.c: 'start' dead code
Summary: rpc_parse/parse_lsa.c: 'start' dead code
Status: RESOLVED INVALID
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Client Tools (show other bugs)
Version: 3.0.9
Hardware: SGI IRIX
: P3 normal
Target Milestone: none
Assignee: Tim Potter
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-01 15:44 UTC by Jason Mader (mail bounces back)
Modified: 2005-02-08 06:28 UTC (History)
0 users

See Also:

Attachments
#if 0 'start' dead code (535 bytes, patch)
2005-01-30 11:43 UTC, Jason Mader (mail bounces back) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader (mail bounces back) 2004-12-01 15:44:08 UTC 
In rpc_parse/parse_lsa.c lines 217 and 225 involved the variable 'start' can either be removed or moved 
into the #idef 0 block later in the function where the 'start' variable might be used.
Comment 1 Jason Mader (mail bounces back) 2005-01-30 11:34:37 UTC 
Actually, it looks like line 217 'uint32 start;' could be moved to just before line 224 'start = 
prs_offset(ps);' and those should be #if 0 out like the later section that actually uses the start variable.
Comment 2 Jason Mader (mail bounces back) 2005-01-30 11:43:10 UTC 
Created attachment 923 [details]
#if 0 'start' dead code
Comment 3 Tim Potter 2005-01-30 15:35:58 UTC 
Sorry - your patch won't work with all compilers.  GCC supports variable
declarations after statements but this isn't the case with all (any?) vendor
compilers.