Bug 2099 - tdb/tdbutil.c: SIG_ATOMIC_T
Summary: tdb/tdbutil.c: SIG_ATOMIC_T
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.0.4
Hardware: SGI IRIX
: P4 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-29 13:30 UTC by Jason Mader (mail bounces back)
Modified: 2005-08-24 10:15 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader (mail bounces back) 2004-11-29 13:30:12 UTC 
cc-1164 cc: WARNING File = tdb/tdbutil.c, Line = 60
  Argument of type "SIG_ATOMIC_T *" is incompatible with parameter of type
          "sig_atomic_t *".

        tdb_set_lock_alarm(&gotalarm);
                           ^

tdb_set_lock_alarm() is defined in tdb.c.  It looks like lines 197 & 199 of tdb.c should be changed to the 
uppercase SIG_ATOMIC_T for consistency with the rest of Samba.  And also line 150 of tdb.h.
Comment 1 Jason Mader (mail bounces back) 2004-12-08 08:21:57 UTC 
Changing to uppercase SIG_ATOMIC_T has side effects; the other tdb files that include "tdb.h" break 
because they don't also include "includes.h".  tdb/tdbtool.c breaks if "includes.h" is included because it 
declares several names and procedures that are already declared in "includes.h".
Comment 2 Gerald (Jerry) Carter (dead mail address) 2005-03-22 10:33:33 UTC 
already fixed.
Comment 3 Gerald (Jerry) Carter (dead mail address) 2005-03-23 09:38:20 UTC 
my mistake.  not fixed.  reopening until I can spend time on it.
Comment 4 Gerald (Jerry) Carter (dead mail address) 2005-03-24 06:26:29 UTC 
lowering priority
Comment 5 Jason Mader (mail bounces back) 2005-03-30 13:06:32 UTC 
This warning has been eliminated by <derrell.lipman@unwireduniverse.com> as part
of changes me made for Bug 2484.
Comment 6 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:15:58 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.