I was trying to figure out why tortoise svn was not able to use my samba share as a drive todo its checkout ... eventually I found that the problem was that svn was not able to set the read-only attribute on files. Further investigation showed that it was possible to remove a read-only attribute but not to set one ... eventually I found that in dosmode.c there is code which checks if the share is in 'inherit permissions mode' if so, it simply throws away any read-only attribut it gets. smbd/dosmode.c:70 /* Clear "result" */ result = 0; if I do not set the inherit permissions flag, all works well. this does not make sense to me, especially because setting all the other attributes works regardles of the inherit permissions flag. any ideas why the result=0 was put in there ? I would assume that permission inheritance is especially interesting for new files, not for existing ones ...
Created attachment 813 [details] Patch gone into SVN.
Fixed this (hopefully) by adding a BOOLean so we know if the file should be new (and thus inherit permissions or not). Please test SVN code. Jeremy.
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.