Bug 2085 - lib/util.c: 'Protocol' is defined with the wrong type
lib/util.c: 'Protocol' is defined with the wrong type
Status: CLOSED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: libsmbclient
3.0.9
SGI IRIX
: P3 normal
: none
Assigned To: Samba Bugzilla Account
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-11-23 20:12 UTC by Jason Mader
Modified: 2005-08-24 10:17 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader 2004-11-23 20:12:19 UTC
Compiling lib/util.c
cc-1185 cc: WARNING File = lib/util.c, Line = 2355
  An enumerated type is mixed with another type.

        return ms_fnmatch(pattern, string, Protocol, is_case_sensitive) == 0;

in the function called on return, Protocol was globally defined an 'int' on line 52, instead of 'enum 
protocol_types' (line 1323 of lib/smb.h).

ms_fnmatch() is defined in lib/ms_fnmatch.c line 149:

  int ms_fnmatch(const char *pattern, const char *string, enum protocol_types protocol, BOOL 
is_case_sensitive)

Protocol should probably be defined as 'enum protocol_types'.
Comment 1 Jeremy Allison 2004-11-24 17:06:54 UTC
Changed Protocol to enum - thanks !
Jeremy.
Comment 2 Gerald (Jerry) Carter 2005-08-24 10:17:17 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.