Bug 2080 - rpc_parse/parse_samr.c: pdb_get_acct_desc() called twice
Summary: rpc_parse/parse_samr.c: pdb_get_acct_desc() called twice
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Client Tools (show other bugs)
Version: 3.0.8
Hardware: All All
: P3 normal
Target Milestone: none
Assignee: Tim Potter
QA Contact: Samba QA Contact
Depends on:
Reported: 2004-11-23 08:15 UTC by Jason Mader (mail bounces back)
Modified: 2005-08-24 10:19 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader (mail bounces back) 2004-11-23 08:15:28 UTC
cc-1552 cc: WARNING File = rpc_parse/parse_samr.c, Line = 1649
  The variable "acct_desc" is set but never used.

                const char *acct_desc;

On line 1656 'acct_desc' is set to pdb_get_acct_desc(pwd) and should be used in the argument to 
init_unistr2() on line 1669 instead of calling pdb_get_acct_desc(pwd) again.
Comment 1 Tim Potter 2004-11-23 13:49:53 UTC
I've checked in a fix - thanks!
Comment 2 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:19:41 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.