Bug 2073 - param/loadparm.c: argument to standard_sub_basic() might be wrong
param/loadparm.c: argument to standard_sub_basic() might be wrong
Product: Samba 3.0
Classification: Unclassified
Component: smbmount (unmaintained)
: P3 normal
: none
Assigned To: Samba Bugzilla Account
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2004-11-21 14:25 UTC by Jason Mader
Modified: 2005-08-24 10:17 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader 2004-11-21 14:25:13 UTC
Compiling param/loadparm.c
cc-1552 cc: WARNING File = param/loadparm.c, Line = 2687
  The variable "username" is set but never used.

        char *username;

On line 2703:
        standard_sub_basic(current_user_info.smb_name, n2,sizeof(n2));

this seems really similar to the use on line 3899:
        standard_sub_basic( username, n2,sizeof(n2) );

possibly, line 2703 should also use 'username'.
Comment 1 Gerald (Jerry) Carter 2004-11-23 07:40:16 UTC
I agree.  Looks right to me.  fixing in svn.
Comment 2 Gerald (Jerry) Carter 2005-08-24 10:17:52 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.