Bug 2061 - avoid inclusion of linux/audit.h
avoid inclusion of linux/audit.h
Product: Samba 3.0
Classification: Unclassified
Component: smbmount (unmaintained)
All Linux
: P3 enhancement
: none
Assigned To: Samba Bugzilla Account
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2004-11-18 07:35 UTC by Lars Müller
Modified: 2004-12-13 11:05 UTC (History)
0 users

See Also:

Define _LINUX_AUDIT_H_ to avoid the inclusion (884 bytes, patch)
2004-11-18 07:36 UTC, Lars Müller
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Müller 2004-11-18 07:35:38 UTC
In newer versions we have to avoid the inclusion of linux/audit.h.
Comment 1 Lars Müller 2004-11-18 07:36:12 UTC
Created attachment 793 [details]
Define _LINUX_AUDIT_H_ to avoid the inclusion
Comment 2 Volker Lendecke 2004-11-18 08:19:44 UTC
Could you explain that one a bit more? Why can't you include that header file?

Comment 3 Lars Müller 2004-11-19 08:11:46 UTC
a) We should never include kernel headers in userspace.
b) This include triggered other includes from kernel headers, and this other
five and so on just to define the needed stricts and types.
c) You risk collissions with the headers of the libc.

So my colleagues from the build team disabled the inclusion of linux/audit.h as
you see in the patch.

The compiler stopped with errors.
Comment 4 Lars Müller 2004-12-13 11:05:57 UTC
But the compiler doesn't complain anymore.  Not for 9.2 nor for the current
development tree.

This fix is superfluous and the report is invalid.