Bug 2015 - file_set_dosmode problem / file attributes
file_set_dosmode problem / file attributes
Status: CLOSED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: File Services
3.0.8
All Linux
: P3 major
: none
Assigned To: Samba Bugzilla Account
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-11-10 15:49 UTC by Daniel Beschorner
Modified: 2005-01-20 11:29 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Beschorner 2004-11-10 15:49:19 UTC
--- branches/SAMBA_3_0_RELEASE/source/smbd/dosmode.c	2004/10/25 19:25:54
3220
+++ branches/SAMBA_3_0_RELEASE/source/smbd/dosmode.c	2004/11/07 20:42:45
3605
@@ -344,7 +344,9 @@
 			return(-1);
 	}
 
-	get_acl_group_bits(conn, fname, &st->st_mode);
+	if (!get_acl_group_bits(conn, fname, &st->st_mode)) {
+		return(-1);
+	}
 
 	if (S_ISDIR(st->st_mode))
 		dosmode |= aDIR;

This change seems to break the setting of file attributes with acl support 
enabled.
Certain files cannot be recreated/deleted or it fails to copy a fresh copied
file a second time on itself. Without this patch it works good as 3.0.7.
If I understand correctly every existence of ACLs (the default case) means an 
return(-1) in file_set_dosmode with this patch.

Daniel
Comment 1 Guenther Deschner 2004-11-10 16:12:21 UTC
reverted that commit. thanks.