Bug 1956 - close_normal_file strange
Summary: close_normal_file strange
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: File Services (show other bugs)
Version: 3.0.7
Hardware: All All
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-21 08:07 UTC by Love
Modified: 2005-08-24 10:19 UTC (History)
0 users

See Also:

Attachments
Patch I applied. (1.60 KB, patch)
2004-10-21 12:51 UTC, Jeremy Allison 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Love 2004-10-21 08:07:02 UTC 
close_normal_file() store the return value in err from fd_close(), but
doesnt preserve the errno, (so check_magic() can stomp it), then the later uses
err to strerror, but err is -1 if fd_close() failes so it doens't provade any real only
Comment 1 Jeremy Allison 2004-10-21 12:51:49 UTC 
Created attachment 740 [details]
Patch I applied.
Comment 2 Jeremy Allison 2004-10-21 12:52:02 UTC 
Fixed in svn. Thanks !
Jeremy.
Comment 3 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:19:34 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.