Bug 1955 - error confusion
error confusion
Status: CLOSED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: File Services
3.0.7
All All
: P3 normal
: none
Assigned To: Samba Bugzilla Account
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-10-21 08:03 UTC by Love
Modified: 2005-08-24 10:24 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Love 2004-10-21 08:03:37 UTC
return False (0) on error vs return 0 on success (fd_close_posix)

int fd_close_posix(struct connection_struct *conn, files_struct *fsp)
[....]
		if (!add_fd_to_close_entry(fsp)) {
			SAFE_FREE(entries);
			return False;
		}

		SAFE_FREE(entries);
		fsp->fd = -1;
		return 0;
Comment 1 Jeremy Allison 2004-10-21 11:39:01 UTC
Fixed in SVN. Thanks !
Jeremy.
Comment 2 Gerald (Jerry) Carter 2005-08-24 10:24:14 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.