Bug 1927 - Tdbtool ascii dump type mis-match fixes.
Summary: Tdbtool ascii dump type mis-match fixes.
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.0.7
Hardware: Alpha OpenVMS
: P3 minor
Target Milestone: none
Assignee: Tim Potter
QA Contact: Samba QA Contact
Depends on:
Reported: 2004-10-13 18:38 UTC by John Malmberg
Modified: 2010-05-03 04:10 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description John Malmberg 2004-10-13 18:38:57 UTC
The routines print_asc() and print_data() are taking a pointer to what is used
as a read only untyped data stream with a length parameter.  The HP C compiler
for VMS is diagnosing a type mismatch when unsigned data is passed.

To more accurately reflect how these routines are used they can be changed to be
as below.

static void print_asc(const void * buf1, int len)
        unsigned char * buf;
        int i;

        buf = (unsigned char *)buf1;

. . . 

static void print_data(const void * buf1, int len)
        unsigned char * buf;
        int i;

        buf = (unsigned char *)buf1;

Comment 1 Volker Lendecke 2010-05-03 04:10:10 UTC
Closing the bug as fixed. The current code has

static void print_asc(const char *buf,int len)
static void print_data(const char *buf,int len)

Please re-open if it's still an issue with current master.