Bug 1926 - getsockname DEBUG written getpeername
Summary: getsockname DEBUG written getpeername
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: File Services (show other bugs)
Version: 3.0.0preX
Hardware: All All
: P3 minor
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-13 13:12 UTC by Bill McGonigle (dead mail address)
Modified: 2005-08-24 10:27 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bill McGonigle (dead mail address) 2004-10-13 13:12:55 UTC 
When looking through the source for a getpeername error I found a line in
source/lib/util_sock.c (line 46 on my copy) that looks like:

static char *get_socket_addr(int fd)
...
	if (getsockname(fd, &sa, &length) < 0) {
		DEBUG(0,("getpeername failed. Error was %s\n", strerror(errno) ));
		return addr_buf;
	}

Ought the DEBUG read 'getsockname failed'?
Comment 1 Jeremy Allison 2004-10-14 15:29:08 UTC 
Applied, thanks.
Jeremy.
Comment 2 Gerald (Jerry) Carter (dead mail address) 2005-02-07 07:57:34 UTC 
originally reported against 3.0aph24.  Bugzilla spring cleaning.  
Removing old alpha versions.
Comment 3 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:27:18 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.