Bug 1898 - winbind_nss.h - HAVE_NSS_H & HAVE_NS_API_H macro tests
Summary: winbind_nss.h - HAVE_NSS_H & HAVE_NS_API_H macro tests
Status: RESOLVED WONTFIX
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.0.7
Hardware: Alpha OpenVMS
: P3 trivial
Target Milestone: none
Assignee: Tim Potter
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-08 20:31 UTC by John Malmberg
Modified: 2010-04-26 03:46 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Malmberg 2004-10-08 20:31:51 UTC
In module winbind_nss.h, and winbind_nss_linux.h it is testing the values of
HAVE_NSS_H and HAVE_NS_API_H but not checking to see if they were defined.

The OpenVMS C compiler is reporting that tests are being done for a value of an
undefined macro, which will be interpreted as being defined to zero.

Because these macros are tested for being defined in other modules, using a
#define HAVE_NS_API_H 0
to suppress the message will work.


If the code in wiinbind_nss.h could be changed to:

#elif defined(HAVE_NSS_H)

and

#elif defined(HAVE_NS_API_H)

It would eliminate the VMS C compiler diagnostics.

A similar change may be useful in the winbind_nss_linux.h module.
Comment 1 Stefan Metzmacher 2010-04-26 03:46:17 UTC
If it's still broken in 3.5, please reopen.
3.0 isn't supported anymore.