Bug 1880 - OpenVMS C Compiler issue with ../foo/foo.h include files.
OpenVMS C Compiler issue with ../foo/foo.h include files.
Status: CLOSED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: Build environment
3.0.7
Alpha OpenVMS
: P3 enhancement
: none
Assigned To: Tim Potter
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-10-06 18:36 UTC by John Malmberg
Modified: 2005-08-24 10:19 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Malmberg 2004-10-06 18:36:56 UTC
The way that OpenVMS resolves the default path for include files means that it
can not really deal with include file paths that have the ".." directory in
their path.

With SAMBA 2.2.X this only affected a few modules, but now with 3.0.7 it is
affecting several modules.

Can the ".." be removed, and the affected directory added to the path for the
compiler to search for the header files.

The alternative is that OpenVMS will need to perform an edit on any file that
uses a "../" to reference an include file.

So it would need:

#ifdef __VMS
#include "web/swat_proto.h"
#else
#include "../web/swat_proto.h"
#endif
Comment 1 Tim Potter 2004-10-06 19:12:03 UTC
The value for CFLAGS already includes -I. and -I$(srcdir) so there is actually
no problem with getting rid of the ../ globally.

You will have to keep an eye on things though and check that they don't creep
back in.
Comment 2 Tim Potter 2004-10-06 21:07:59 UTC
I've checked in a (big) patch.  Let me know if this doesn't fix the problem for you.
Comment 3 Gerald (Jerry) Carter 2005-08-24 10:19:47 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.