Bug 1873 - rsync doesn't obey .cvsignore (exclamation) ! semantics
Summary: rsync doesn't obey .cvsignore (exclamation) ! semantics
Status: CLOSED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 2.6.3
Hardware: All All
: P3 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-05 16:37 UTC by aptosca
Modified: 2005-04-01 11:22 UTC (History)
0 users

See Also:

Attachments
Re-enable "!"s in .cvsignore files (1.10 KB, patch)
2004-10-05 17:08 UTC, Wayne Davison 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description aptosca 2004-10-05 16:37:26 UTC 
In a .cvsignore file, an excalmation point (!) on a line by itself is used to 
clear the exclusion list, including builtins.  rsync has done this in the 
past, but changed at some point ... I didn't trace the CVS logs for the change.

In excludes.c, ! is getting flagged off with the other meta-characters when in 
this case, allowing it would follow the (useful) CVS semantics.
Comment 1 Wayne Davison 2004-10-05 17:08:12 UTC 
Created attachment 702 [details]
Re-enable "!"s in .cvsignore files

I had thought that the bang token was an rsync-ism, but I apparently missed
that it was also the only valid special-token in a .cvsignore file.  This patch
restores its list-clearing behavior in a .cvsignore file.
Comment 2 Wayne Davison 2004-10-05 17:19:34 UTC 
I've checked-in the fix to CVS.