Bug 15688 - per user veto and hide file syntax is to complex
Summary: per user veto and hide file syntax is to complex
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.21.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-30 12:39 UTC by Stefan Metzmacher
Modified: 2024-08-13 17:03 UTC (History)
3 users (show)

See Also:

Attachments
Patches for v4-21-test (27.76 KB, patch)
2024-07-31 09:58 UTC, Stefan Metzmacher 		vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2024-07-30 12:39:26 UTC 
As discussed in https://gitlab.com/samba-team/samba/-/merge_requests/3498,
the syntax using '/../USERNANE/FILENAME/' is too complex.

So instead of
veto files = /veto_name*/../user1/user1file/../user2/user2file/../+group1/group1file/../+group2/group2file

we should have this instead:

       veto files = /veto_name*/
       veto files : user2 = /user2file/
       veto files : +group2 = /group2file/
       veto files : user1 = /user1file/
       veto files : +group1 = /group1file/
Comment 1 Samba QA Contact 2024-07-31 09:42:04 UTC 
This bug was referenced in samba master:

0536ac96e927c00121e220f45cd63682726bc8e3
89da15756d81746d80b43c2fe04c51fc07591849
fcd595a4642a08169b427af534a00116daf220bf
17becb5f526015de56d00cd1c8f603f8ddacd0ba
b5a128685e68f05a3688aa1391393b9095bf32b0
b5169dd717ed5cf66d1e1e90aaf1a4646f7b5ea5
a150714cc64294d75028bac47132084bdf6f72c9
10e9b858a3f9ca8d7e5dfd1c4e1e7937a03db671
Comment 2 Stefan Metzmacher 2024-07-31 09:58:39 UTC 
Created attachment 18387 [details]
Patches for v4-21-test
Comment 3 Samba QA Contact 2024-07-31 16:08:04 UTC 
This bug was referenced in samba v4-21-test:

5148ff97061c1eb10c66c84e4e353daae7a5a17b
0b9371aa0c22684bb9d168a67891d92107023736
af0085aced4f2a7c8a11bbf357dc25b5ceb0928a
fd73c865eed811d89da023a77792aba7a603fc60
244ade4f12c0b9f72ffd640cd16a6c1a2c1ce37e
13dbaf5556c6a3778d384ed833a896e266546557
d5be00ab537b2e5256926c4753793b4ce561956d
bffa9349d425bcb2b4532ea27194d4a0727b6d31
5ba371e09ab284e4ada0e6f3275a07711e7dd069
Comment 4 Samba QA Contact 2024-08-13 17:03:31 UTC 
This bug was referenced in samba v4-21-stable (Release samba-4.21.0rc2):

5148ff97061c1eb10c66c84e4e353daae7a5a17b
0b9371aa0c22684bb9d168a67891d92107023736
af0085aced4f2a7c8a11bbf357dc25b5ceb0928a
fd73c865eed811d89da023a77792aba7a603fc60
244ade4f12c0b9f72ffd640cd16a6c1a2c1ce37e
13dbaf5556c6a3778d384ed833a896e266546557
d5be00ab537b2e5256926c4753793b4ce561956d
bffa9349d425bcb2b4532ea27194d4a0727b6d31
5ba371e09ab284e4ada0e6f3275a07711e7dd069