Have patchset for master, need bug.
This bug was referenced in samba master: 3720452720b4760509875f0d2a8ed0d104bb1844 192b0cf8717d79197b985539c9db8ca07a89c570 1b78d79663c48aa4b6810a875427de85ae49a2e8 93d786b14358db5664e13b1aa43f3f03e7cf0be3 47224fbdeb55100cf8a7ee75e13b954ab71fc158 beb21324c9a554f50d8d99af2a1b7fe8a17c8ebb 31085c7efc3572bd6200d3d8e49c1e554cdbfbcc 491676846458980944b76d1693726627a9a32503 f16183f90abba3c2d3d26262926f1454275a9d3f 13671cefffb268d84c973583669681318a2ce3bb a8a7339c6b7a6866399fd6c409228267a585740f bd955af86e71fa6c87648e578890ea6f4d490d4b 99c7179e5da6d201f03b1a04dbe2a6722090783d 24a3423949e127177c019a0d126c6f7523e61984 cb14d3630d8c110405c2a43bef15aa31ec4a0fba 20b7d2bfe06beefb5e7f091eb317ad18cb53f8a9 362a7cf8664270145bff815347e447797cc1a643 53c9269b219a54236500d22d8a4c7f2ed582faaf 29bbe0f52d4ffae9dbb070ffc525acf99203444b 30c1a613fee3f625c0559e49e037af9fad04c3b8 e15586fc6097565208011c556282d83eeec2230b b536bf1fa87fb794e2992ab5368f41fdba80e3ad 9a70bd606728110ad91cab547a4e31350010bb68 83011357fb834e92505f17d6f65d5f32e3d37ec0 e714e5ddc50a771e743f5e63f686c106abe33b75 0a8445e891c64d703d44258b2eef85296265c55f d00f20f30f4e77463e82d202099682b7ef68260f 3bb6d441bf047bef6d95675057cecd3865a25540
WARNING !!!! Setting errno=0 on success will cause real errors to get hidden !! There is code in Samba that expects errno from a previous system call to be preserved through a subsequent system call. Please remove the "errno=0" from status_code() and lstatus_code(). static int status_code(int ret) { if (ret < 0) { errno = -ret; return -1; } errno = 0; return ret; } static ssize_t lstatus_code(intmax_t ret) { if (ret < 0) { errno = -((int)ret); return -1; } errno = 0; return (ssize_t)ret; }
Just for the record, followup MR with fixes is provided here: https://gitlab.com/samba-team/samba/-/merge_requests/3742
I tried testing the current version of ceph_new on my ceph cluster using the new smb mgr module. When I tested it I was unable to log into the share using ceph_new. I added a share for the same dir using just ceph and it worked. I got logging (see below) and it seems to indicate that the ceph_select_filesystem operation is not available. I removed the param ceph:filesystem from the config and it started to work too. The smb module puts ceph:filesystem into every share it creates for consistency (plus it probably means a 2nd filesystem wouldn't work either). ``` Allowed connection from 127.0.0.1 (127.0.0.1) Connection allowed from ipv4:127.0.0.1:40466 to ipv4:127.0.0.1:445 cephmount_select_fs: [CEPH] ceph_select_filesystem not available messaging_dgm_send: Sending message to 23 messaging_recv_cb: Received message 0x314 len 0 (num_fds:0) from 2 smbd_cleanupd_process_exited: cleaned up pid 684 ```
(In reply to John Mulligan from comment #4) https://gitlab.com/samba-team/samba/-/merge_requests/3748 created to address the issue.
This bug was referenced in samba master: d8c84a2993b84ebb69011c33c1b5d44801c15363 de2f76fa47e6e672ce353ea9d3dc4019965c6491
This bug was referenced in samba master: a7f4e2bd47c7f4728f3ac8d90af693156a69c557 aa043a5808b73fc272de585c1446372fa3f21d08
Created attachment 18398 [details] patch from master for v4-21-test
This bug was referenced in samba master: aca4cf8327dcaef782dedd98a63a020469c45cdb 68f0835c8e1c5029cd831c267b75c02185b206c7
Created attachment 18399 [details] patch (v2) from master for v4-21-test
Created attachment 18400 [details] patch (v2) from master for v4-20-test
Reassigning to Jule for inclusion into 4.20 and 4.21.
For the 4.20 backport a7f4e2bd47c7f4728f3ac8d90af693156a69c557 is skipped for the old module. WRAP_RETURN() having 'errno = 0', is not a problem?
We also need WHATSNEW patches
This bug was referenced in samba v4-21-test: 74524c438b7da962c352d1f5150a813c62942c9a 5a7f6e4610e6abe2b39b453534fe3e417e3771ba 9f68daaccc5cfc3a448b0cb1500f98cf0a13b078 8e28065f560d611a35a182d5ceef426110b3dbbf be427077ce8e19ee2fa2e6f481ae40c321e1cb20 7bb3f5f251a0158195dcc6a7ec826ccdbd70e04d f3e5d7237bea4e7fa1935c18f185cb76730d1160 62a43faa114fb18365c9f720ffc75570c2fb126d 6fdf1922a99becf6b03d6a5f5049d7d8ccdd2470 655e7a1508cd2f8a4dd4c698f38f2af0a0af126a 34c848251cd61fc8eef1bfb7238c5944ae8e8545 5eaa87494688c8c647ad723e335a198376a030e8 9fd6c5b41f4cff0671aed7d786624ac35e495fcd 26851f16fc2fb0e373871eece566a47b3d8e9a8b 7780114ab028c9cbf20a832b28eed75619afef91 2b660aaf9ed39fd32ff5cee9063865f7a94aef7f 9278e661146d89df128b6b9728b21fcc88b1a0b2 69b671dcbfe7f933efe2addbe5f3d66203839506 ddb5fcb2faf4085ce4d613df18ca6435cf93c310 f429baca5cf070581de37ba372f001f6bcae2186 dc207c281cde80429d80232c7791b71e34d5e013 2b1c65948c3b9d31adbbd283382c5bf88f08e436 6af3cb81a00c50c4d1b2a812ef1a6d02c8ec0b1a 9109ed18720972474816fa192f52f9f743deb20d e0d2953a847b784b2157cf0a48b4c25036b1a53a ec119531a4f386c32aa4d5d06521a15d1ffb7702 9de33d3442c93dfd8bb81d1ac0d8888065a91f0f fe3471eb5b293547ad1c3342f71f445e08f8f6ae ff2ecedd6f9fd9fa8b2b6278e9a0339c9d8b03b0 0d03161324ce7d89606c75bb957cf78bbb81c3b6 7872fbd907b6917e1863a3df9fb50b0b6139ea2e 0edfc053743ef929784824a67749e1eb683e5dc2 ab1db57e9a775c958831ec112bbcc1244c643036 7477658193eb6e310c631a2ad39082cafb284843
This bug was referenced in samba v4-21-stable (Release samba-4.21.0rc2): 74524c438b7da962c352d1f5150a813c62942c9a 5a7f6e4610e6abe2b39b453534fe3e417e3771ba 9f68daaccc5cfc3a448b0cb1500f98cf0a13b078 8e28065f560d611a35a182d5ceef426110b3dbbf be427077ce8e19ee2fa2e6f481ae40c321e1cb20 7bb3f5f251a0158195dcc6a7ec826ccdbd70e04d f3e5d7237bea4e7fa1935c18f185cb76730d1160 62a43faa114fb18365c9f720ffc75570c2fb126d 6fdf1922a99becf6b03d6a5f5049d7d8ccdd2470 655e7a1508cd2f8a4dd4c698f38f2af0a0af126a 34c848251cd61fc8eef1bfb7238c5944ae8e8545 5eaa87494688c8c647ad723e335a198376a030e8 9fd6c5b41f4cff0671aed7d786624ac35e495fcd 26851f16fc2fb0e373871eece566a47b3d8e9a8b 7780114ab028c9cbf20a832b28eed75619afef91 2b660aaf9ed39fd32ff5cee9063865f7a94aef7f 9278e661146d89df128b6b9728b21fcc88b1a0b2 69b671dcbfe7f933efe2addbe5f3d66203839506 ddb5fcb2faf4085ce4d613df18ca6435cf93c310 f429baca5cf070581de37ba372f001f6bcae2186 dc207c281cde80429d80232c7791b71e34d5e013 2b1c65948c3b9d31adbbd283382c5bf88f08e436 6af3cb81a00c50c4d1b2a812ef1a6d02c8ec0b1a 9109ed18720972474816fa192f52f9f743deb20d e0d2953a847b784b2157cf0a48b4c25036b1a53a ec119531a4f386c32aa4d5d06521a15d1ffb7702 9de33d3442c93dfd8bb81d1ac0d8888065a91f0f fe3471eb5b293547ad1c3342f71f445e08f8f6ae ff2ecedd6f9fd9fa8b2b6278e9a0339c9d8b03b0 0d03161324ce7d89606c75bb957cf78bbb81c3b6 7872fbd907b6917e1863a3df9fb50b0b6139ea2e 0edfc053743ef929784824a67749e1eb683e5dc2 ab1db57e9a775c958831ec112bbcc1244c643036 7477658193eb6e310c631a2ad39082cafb284843
Created attachment 18412 [details] Patch for WHATSNEW.TXT
Pushed to autobuild-v4-20-test. WHATSNEW patch was applied.
This bug was referenced in samba v4-21-test: 12084aa1bda8ac1c624d71fb6003e1bc5e669d5f
This bug was referenced in samba v4-21-stable (Release samba-4.21.0rc3): 12084aa1bda8ac1c624d71fb6003e1bc5e669d5f
This bug was referenced in samba v4-20-test: 565fe2e2f4c23644a3909b40ffa0c9917e9c6de1 94aa465513e54167b3d39180aa4e0e70f93fcc26 30d2e62c399736c505305c24ba737763337f31cd 8aa247461bb23a98a1e0ca4c6f6ccbe434bdc51f 1a9d6754c25ef311a0d71990f1408752edeef4ca 8d2255e5898b03ac1475746ed80425a842021056 d81835ab8ea47cce1efac5b621bfba5b91e6217a 76dd52023b0a349ead38e8a81cf8a3a5eb1adce0 73ef8906b3fefc105be9fd520ccfe857b6c1af09 dff808b32a4502fae2103031f47674c1ec240db9 cf7fd4172ab1fbb694c8894a66a1731ab22c2180 7c1f160f83899a37e618c83f0bc86dce889ec3e2 6403fb8d5acd84c3ff84a14e9ab4cebeded8ecde 62758ba3d4897d317b8ee1167d9cec80dfecdf09 946921a5191131a439b4116aef8ed5c542edd376 b9b5dab06c5e6c529327d2c1fb343996a941807c 6b79716d2f605d0fbd200f2e5c3f3005e4417eba 4b53a5e3910a094956f5bff86620b01e1f70c680 9d51b996bfe889653349bc172d55bc6fedcc8c84 61d7c591deedb9d61e57c06aa28decc356bf4b42 dda8b67432005ed11401773bda6b384b28b1391f 2583b0e8829d584c5040edfb8ecc720e332c3995 405a93f07cea4aa31a15de457e49abbc539058cc 0ab6fa78a4b7abda52616f65120335270ae11c4d 34f9de8bbe3142dd12825ec4407b24b41a381bb4 07579685b91c70f743121bc6e1b3bcf07ab738e7 c569dfcb8bcc89037e39869ecf90655d4f7bdf83 f399191fba551f429874315b938b83a6ed1d040c a78c9b0a5053fbe3363aedbd131de04780162909 0042d902498d2640c0f36b22f4b4c8fee63b24b4 07f156d8436ac5ecbfd99e88231625351b54e16e ce958aeef1afe8e54c82383ac81ab9765c78e040 a8c3db7e21e0e0696e15166a5ed683cdb3d44034 bb8d642a1402c9d625e02d610d973a34b83ef3a2
Created attachment 18414 [details] patch from master for v4-20-test (part 2) (In reply to Stefan Metzmacher from comment #13) I agree with metze's concern here and would like to address it with another patch set(part 2) for 4.20. Can you please consider the attached change for inclusion into 4.20?
Pushed to autobuild-v4-20-test.
The patch set does not compile in 4.20. Reassigning to Anoop.
Created attachment 18417 [details] patch from master for v4-20-test (part 2) (In reply to Jule Anger from comment #24) Sorry for the trouble. Can you please try the updated version(which compiles locally for me) with 2 more additional changes cherry-picked from master?
This bug was referenced in samba master: cbba4008a7fb9e6e91d0568f25ac481b60fda96f
This bug was referenced in samba v4-20-test: 33452ce95ff1f32ab1cd4d53a63dc2d7d9861bf0 a9d32a3b96f6d8bbfcdc40bf3547be4f3dd750c8 67c90dec0a8f63acc467ac970bd518e9e384a66f 92712fc7e27e21fc279f73f0fe9803f67269967b b9d9bec51c3a7a0fdd51b69b892173974352c7ac
This bug was referenced in samba master: 22182f90e8e7876a9895f77e736d2b96b18b174f
Created attachment 18428 [details] patch from master for v4-20-test (part 3)
Created attachment 18429 [details] patch from master for v4-21-test (part 2)
Comment on attachment 18428 [details] patch from master for v4-20-test (part 3) LGTM, RB+
Comment on attachment 18429 [details] patch from master for v4-21-test (part 2) LGTM, RB+
Jule, please pick those remaining patches as well for 4.20 and 4.21, thanks!
Pushed to autobuild-v4-{21,20}-test.
This bug was referenced in samba v4-21-test: 06cf7b7b6f96082ea17fb64724cb0957c11c0d7a 6071ea83333259c98237a0a14dd6c1937f9348e2
This bug was referenced in samba v4-21-stable (Release samba-4.21.0): 06cf7b7b6f96082ea17fb64724cb0957c11c0d7a 6071ea83333259c98237a0a14dd6c1937f9348e2
This bug was referenced in samba v4-20-test: acb3de1cf9a513c62cf81a6504990df61cfcaaaf 60052ea77a32f9473465b1fd92e58663dea60604
This bug was referenced in samba v4-20-stable (Release samba-4.20.5): 565fe2e2f4c23644a3909b40ffa0c9917e9c6de1 94aa465513e54167b3d39180aa4e0e70f93fcc26 30d2e62c399736c505305c24ba737763337f31cd 8aa247461bb23a98a1e0ca4c6f6ccbe434bdc51f 1a9d6754c25ef311a0d71990f1408752edeef4ca 8d2255e5898b03ac1475746ed80425a842021056 d81835ab8ea47cce1efac5b621bfba5b91e6217a 76dd52023b0a349ead38e8a81cf8a3a5eb1adce0 73ef8906b3fefc105be9fd520ccfe857b6c1af09 dff808b32a4502fae2103031f47674c1ec240db9 cf7fd4172ab1fbb694c8894a66a1731ab22c2180 7c1f160f83899a37e618c83f0bc86dce889ec3e2 6403fb8d5acd84c3ff84a14e9ab4cebeded8ecde 62758ba3d4897d317b8ee1167d9cec80dfecdf09 946921a5191131a439b4116aef8ed5c542edd376 b9b5dab06c5e6c529327d2c1fb343996a941807c 6b79716d2f605d0fbd200f2e5c3f3005e4417eba 4b53a5e3910a094956f5bff86620b01e1f70c680 9d51b996bfe889653349bc172d55bc6fedcc8c84 61d7c591deedb9d61e57c06aa28decc356bf4b42 dda8b67432005ed11401773bda6b384b28b1391f 2583b0e8829d584c5040edfb8ecc720e332c3995 405a93f07cea4aa31a15de457e49abbc539058cc 0ab6fa78a4b7abda52616f65120335270ae11c4d 34f9de8bbe3142dd12825ec4407b24b41a381bb4 07579685b91c70f743121bc6e1b3bcf07ab738e7 c569dfcb8bcc89037e39869ecf90655d4f7bdf83 f399191fba551f429874315b938b83a6ed1d040c a78c9b0a5053fbe3363aedbd131de04780162909 0042d902498d2640c0f36b22f4b4c8fee63b24b4 07f156d8436ac5ecbfd99e88231625351b54e16e ce958aeef1afe8e54c82383ac81ab9765c78e040 a8c3db7e21e0e0696e15166a5ed683cdb3d44034 bb8d642a1402c9d625e02d610d973a34b83ef3a2 33452ce95ff1f32ab1cd4d53a63dc2d7d9861bf0 a9d32a3b96f6d8bbfcdc40bf3547be4f3dd750c8 67c90dec0a8f63acc467ac970bd518e9e384a66f 92712fc7e27e21fc279f73f0fe9803f67269967b b9d9bec51c3a7a0fdd51b69b892173974352c7ac acb3de1cf9a513c62cf81a6504990df61cfcaaaf 60052ea77a32f9473465b1fd92e58663dea60604