Bug 15674 - cmdline_burn does not always burn secrets
Summary: cmdline_burn does not always burn secrets
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Tools (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Douglas Bagnall
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-27 04:52 UTC by Douglas Bagnall
Modified: 2024-07-20 06:35 UTC (History)
2 users (show)

See Also:


Attachments
patch for Samba 4.20 (33.71 KB, patch)
2024-07-17 00:24 UTC, Jo Sutton
no flags Details
patch for Samba 4.19 (33.77 KB, patch)
2024-07-17 00:25 UTC, Jo Sutton
no flags Details
patch for Samba v4.20 version 2 (33.81 KB, patch)
2024-07-20 06:34 UTC, Douglas Bagnall
dbagnall: review? (jsutton)
Details
patch for Samba 4.19 version 2 (33.87 KB, patch)
2024-07-20 06:35 UTC, Douglas Bagnall
dbagnall: review? (jsutton)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Bagnall 2024-06-27 04:52:20 UTC
`--password secret-123` is not burnt (or any other password of length 10 separated from --password by a space).

`--password secret-123 --help` will burn the string "--help" instead of "secret-123".
Comment 1 Samba QA Contact 2024-07-03 02:36:28 UTC
This bug was referenced in samba master:

f17a2b1b25f2ffa5e3caeb8f81101e66b843cc29
05128a1f5f17c55a8d8da42c6c52c4235adf36d4
2f6020cf3dadf484251701040e09a10fba2f644e
53a1184525279741e116350a9b53da15cb2f41d0
d3d8dffc0212662456a6251baee5afd432160fa2
f5233ddf974f9649d8a12b151b6843412eab489c
6effed31899a1be8194a851e5a4023276b8a5f38
c4df89e9640c1306aa390cdacaa974c870c3f5bb
f1fbba6dc609590854c0d7c5e72b58fabc356695
97be45f9ea3410392cd37eab5cfafd3ad00cfe57
Comment 2 Samba QA Contact 2024-07-10 06:29:03 UTC
This bug was referenced in samba master:

86843685419921e28c37f3c1b33011f14940e02f
Comment 3 Jo Sutton 2024-07-17 00:24:39 UTC
Created attachment 18376 [details]
patch for Samba 4.20
Comment 4 Jo Sutton 2024-07-17 00:25:11 UTC
Created attachment 18377 [details]
patch for Samba 4.19
Comment 5 Douglas Bagnall 2024-07-20 05:34:27 UTC
Comment on attachment 18377 [details]
patch for Samba 4.19

It looks like I missed out the BUG= for a couple of the patches, which I guess we should add for the backports.

Thanks for including the #15672 and #15671 patches.
Comment 6 Douglas Bagnall 2024-07-20 06:34:30 UTC
Created attachment 18381 [details]
patch for Samba v4.20 version 2

I've manually edited the patch files (which otherwise look right) to add the missing BUG: lines.
Comment 7 Douglas Bagnall 2024-07-20 06:35:19 UTC
Created attachment 18382 [details]
patch for Samba 4.19 version 2