Bug 15674 - cmdline_burn does not always burn secrets
Summary: cmdline_burn does not always burn secrets
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Tools (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-27 04:52 UTC by Douglas Bagnall
Modified: 2024-08-15 12:14 UTC (History)
2 users (show)

See Also:


Attachments
patch for Samba 4.20 (33.71 KB, patch)
2024-07-17 00:24 UTC, Jennifer Sutton
no flags Details
patch for Samba 4.19 (33.77 KB, patch)
2024-07-17 00:25 UTC, Jennifer Sutton
no flags Details
patch for Samba v4.20 version 2 (33.81 KB, patch)
2024-07-20 06:34 UTC, Douglas Bagnall
jsutton: review+
Details
patch for Samba 4.19 version 2 (33.87 KB, patch)
2024-07-20 06:35 UTC, Douglas Bagnall
jsutton: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Bagnall 2024-06-27 04:52:20 UTC
`--password secret-123` is not burnt (or any other password of length 10 separated from --password by a space).

`--password secret-123 --help` will burn the string "--help" instead of "secret-123".
Comment 1 Samba QA Contact 2024-07-03 02:36:28 UTC
This bug was referenced in samba master:

f17a2b1b25f2ffa5e3caeb8f81101e66b843cc29
05128a1f5f17c55a8d8da42c6c52c4235adf36d4
2f6020cf3dadf484251701040e09a10fba2f644e
53a1184525279741e116350a9b53da15cb2f41d0
d3d8dffc0212662456a6251baee5afd432160fa2
f5233ddf974f9649d8a12b151b6843412eab489c
6effed31899a1be8194a851e5a4023276b8a5f38
c4df89e9640c1306aa390cdacaa974c870c3f5bb
f1fbba6dc609590854c0d7c5e72b58fabc356695
97be45f9ea3410392cd37eab5cfafd3ad00cfe57
Comment 2 Samba QA Contact 2024-07-10 06:29:03 UTC
This bug was referenced in samba master:

86843685419921e28c37f3c1b33011f14940e02f
Comment 3 Jennifer Sutton 2024-07-17 00:24:39 UTC
Created attachment 18376 [details]
patch for Samba 4.20
Comment 4 Jennifer Sutton 2024-07-17 00:25:11 UTC
Created attachment 18377 [details]
patch for Samba 4.19
Comment 5 Douglas Bagnall 2024-07-20 05:34:27 UTC
Comment on attachment 18377 [details]
patch for Samba 4.19

It looks like I missed out the BUG= for a couple of the patches, which I guess we should add for the backports.

Thanks for including the #15672 and #15671 patches.
Comment 6 Douglas Bagnall 2024-07-20 06:34:30 UTC
Created attachment 18381 [details]
patch for Samba v4.20 version 2

I've manually edited the patch files (which otherwise look right) to add the missing BUG: lines.
Comment 7 Douglas Bagnall 2024-07-20 06:35:19 UTC
Created attachment 18382 [details]
patch for Samba 4.19 version 2
Comment 8 Jule Anger 2024-07-23 07:29:44 UTC
Pushed to autobuild-v4-{20,19}-test.
Comment 9 Samba QA Contact 2024-07-23 08:44:11 UTC
This bug was referenced in samba v4-19-test:

0b94b86f3505c7e963d78f2987e10ce0ef3487a4
245fe4d50183671771986fd66ae7cc8b404720ed
22a6e45541cf489b07bb81560d3fb700bf68673a
d87b5a9723f25daa98cba6277be57fa71456057e
0285ea8c1ea3b4f80aab78187a2437b7aed4903c
83de4276f06618ea35dedd2ec6d108dced0bb310
c01499cde1ae6589b94d02763911d730ad515b69
ae462aa71afd5322e22c147a7d8a56a9ef48e286
0c7a0ff715d105f9746e7e92e5f00cac41a8f23e
bfdd8d17d00d3bde92a118eb7e3d7a77e1e03989
e35d6aeb4eb2a926dea0cf3f7e210553469deeb3
0c6749b12686d154a765055f08c6a66a971ced4e
2b35eab717b9d9f99c0697ad71dd9057d749d91f
Comment 10 Samba QA Contact 2024-07-23 08:57:13 UTC
This bug was referenced in samba v4-20-test:

9cbb5bdd333cdb9747681426acf9c99bb376c247
f900e532c3d33d6abbaa54dfe46c3006b3732c93
25329b3863476106341ae043c3c7a946167e3fb0
916d5bde84a35a98c0c0fd2de8de17fbd34dcf34
1315b61e1fb99d3ec8ee50718ef656b02ac4cb43
66da23459f561d56a7a7cdc470c6a8b932faa5d6
0d89d09674a7033062d0b4697d208e3e471c0dc1
6bcdbdab57c625c2c279bcd3253e1eecb2b00389
481eb6ab31edf537292d3867ee3263e54b1fca80
8560c854d4c0dc4c0a4fccccdc072a7e358162e7
957654ebe9d2811d169f299bd60a646474dbd909
93d345467e7276b9a234aeaf71f496ef6fdd7d22
d6f010090ce0abe4276a78f585208e9d02650568
Comment 11 Jule Anger 2024-07-23 09:02:22 UTC
Closing out bug report.

Thanks!
Comment 12 Samba QA Contact 2024-08-02 12:14:08 UTC
This bug was referenced in samba v4-20-stable (Release samba-4.20.3):

9cbb5bdd333cdb9747681426acf9c99bb376c247
f900e532c3d33d6abbaa54dfe46c3006b3732c93
25329b3863476106341ae043c3c7a946167e3fb0
916d5bde84a35a98c0c0fd2de8de17fbd34dcf34
1315b61e1fb99d3ec8ee50718ef656b02ac4cb43
66da23459f561d56a7a7cdc470c6a8b932faa5d6
0d89d09674a7033062d0b4697d208e3e471c0dc1
6bcdbdab57c625c2c279bcd3253e1eecb2b00389
481eb6ab31edf537292d3867ee3263e54b1fca80
8560c854d4c0dc4c0a4fccccdc072a7e358162e7
957654ebe9d2811d169f299bd60a646474dbd909
93d345467e7276b9a234aeaf71f496ef6fdd7d22
d6f010090ce0abe4276a78f585208e9d02650568
Comment 13 Samba QA Contact 2024-08-15 12:14:44 UTC
This bug was referenced in samba v4-19-stable (Release samba-4.19.8):

0b94b86f3505c7e963d78f2987e10ce0ef3487a4
245fe4d50183671771986fd66ae7cc8b404720ed
22a6e45541cf489b07bb81560d3fb700bf68673a
d87b5a9723f25daa98cba6277be57fa71456057e
0285ea8c1ea3b4f80aab78187a2437b7aed4903c
83de4276f06618ea35dedd2ec6d108dced0bb310
c01499cde1ae6589b94d02763911d730ad515b69
ae462aa71afd5322e22c147a7d8a56a9ef48e286
0c7a0ff715d105f9746e7e92e5f00cac41a8f23e
bfdd8d17d00d3bde92a118eb7e3d7a77e1e03989
e35d6aeb4eb2a926dea0cf3f7e210553469deeb3
0c6749b12686d154a765055f08c6a66a971ced4e
2b35eab717b9d9f99c0697ad71dd9057d749d91f