Bug 1564 - spoolss.addprinterdriver fails with WERR_BADFILE because py_to_DRIVER_INFO_3 wasn't finished
Summary: spoolss.addprinterdriver fails with WERR_BADFILE because py_to_DRIVER_INFO_3 ...
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: python (show other bugs)
Version: 3.0.6
Hardware: All Linux
: P3 normal
Target Milestone: none
Assignee: Tim Potter
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-27 11:32 UTC by Daniel Jarboe
Modified: 2005-08-24 10:18 UTC (History)
0 users

See Also:

Attachments
complete to_dependentfiles implementation (3.09 KB, patch)
2004-07-27 11:37 UTC, Daniel Jarboe 		no flags Details
revised patch (3.08 KB, patch)
2004-07-28 04:35 UTC, Daniel Jarboe 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Jarboe 2004-07-27 11:32:08 UTC 
spoolss.addprinterdriver fails with WERR_BADFILE

Samba log:
[2004/07/26 10:44:28, 0] printing/nt_printing.c:move_driver_to_download_area
(1604)
  move_driver_to_download_area: Unable to rename [W32X86/æ¡æ£] to 
[W32X86/3/æ¡æ£]

(python/py_spoolss_drivers_conv.c) py_to_DRIVER_INFO_3 calls
to_dependentfiles which returns a hardcoded uint16* "abcd\0".

Patch below

~ Daniel
Comment 1 Daniel Jarboe 2004-07-27 11:37:26 UTC 
Created attachment 582 [details]
complete to_dependentfiles implementation

pass along spoolss_addprinterdriver's TALLOC_CTX* for
the new info->dependentfiles allocation
Comment 2 Daniel Jarboe 2004-07-28 04:35:27 UTC 
Created attachment 585 [details]
revised patch

fix bad diff against py_spoolss.h, move new TALLOC_CTX args to end to match
style of py_to_PRINTER_INFO_2 and py_to_PRINTER_INFO_3.
Comment 3 Gerald (Jerry) Carter (dead mail address) 2005-02-07 09:58:11 UTC 
originally against 3.0.5rc1 (which became 3.0.6rc1 due to security release)

tpot, still an issue ?
Comment 4 Tim Potter 2005-02-08 13:19:07 UTC 
Checked in - finally!   Sorry about the wait.
Comment 5 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:18:56 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.