Bug 15633 - samba-gpupdate - Invalid NtVer in netlogon_samlogon_response
Summary: samba-gpupdate - Invalid NtVer in netlogon_samlogon_response
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Python (show other bugs)
Version: 4.19.5
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-15 05:33 UTC by Andreas Schneider
Modified: 2024-06-19 14:35 UTC (History)
4 users (show)

See Also:

Attachments
patch for 4.20 (1.32 KB, patch)
2024-04-22 08:44 UTC, Andreas Schneider 		asn: review? (dmulder)
asn: review? (ab)
pfilipensky: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2024-04-15 05:33:41 UTC 
Traceback (most recent call last):
  File "/usr/sbin/samba-gpupdate", line 131, in <module>
    rsop(lp, creds, store, gp_extensions, username, opts.target)
  File "/usr/lib64/python3.12/site-packages/samba/gp/gpclass.py", line 1069, in rsop
    gpos = get_gpo_list(dc_hostname, creds, lp, username)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/site-packages/samba/gp/gpclass.py", line 892, in get_gpo_list
    site_dn = site_dn_for_machine(samdb, dc_hostname, lp, creds, username)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/site-packages/samba/gp/gpclass.py", line 780, in site_dn_for_machine
    raise RuntimeError('site_dn_for_machine: Invalid NtVer in '
RuntimeError: site_dn_for_machine: Invalid NtVer in netlogon_samlogon_response
smb_krb5_trace_cb: [52671] 1712733561.290729: Destroying ccache MEMORY:0x5556ec4225a0


Patch will follow.
Comment 1 Andreas Schneider 2024-04-17 13:41:36 UTC 
I need to just check for the NETLOGON_NT_VERSION_5EX bit

        nt_version               : 0x00000015 (21)
               1: NETLOGON_NT_VERSION_1    
               0: NETLOGON_NT_VERSION_5    
               1: NETLOGON_NT_VERSION_5EX  
               0: NETLOGON_NT_VERSION_5EX_WITH_IP
               1: NETLOGON_NT_VERSION_WITH_CLOSEST_SITE
               0: NETLOGON_NT_VERSION_AVOID_NT4EMUL
               0: NETLOGON_NT_VERSION_PDC  
               0: NETLOGON_NT_VERSION_IP   
               0: NETLOGON_NT_VERSION_LOCAL
               0: NETLOGON_NT_VERSION_GC
Comment 2 Samba QA Contact 2024-04-17 19:33:04 UTC 
This bug was referenced in samba master:

7a5e7b821259890dd2978e6f113f4a3dad110ea4
Comment 3 Andreas Schneider 2024-04-22 08:44:46 UTC 
Created attachment 18291 [details]
patch for 4.20
Comment 4 Andreas Schneider 2024-06-05 12:12:59 UTC 
Jule, please apply the patch to 4.20. Thanks :-)
Comment 5 Jule Anger 2024-06-05 13:02:00 UTC 
Pushed to autobuild-v4-20-test.
Comment 6 Samba QA Contact 2024-06-05 15:02:03 UTC 
This bug was referenced in samba v4-20-test:

1917b7f052dc7cb69f544e1f1ef94b48dd4212fb
Comment 7 Jule Anger 2024-06-10 13:20:53 UTC 
Closing out bug report.

Thanks!
Comment 8 Samba QA Contact 2024-06-19 14:35:09 UTC 
This bug was referenced in samba v4-20-stable (Release samba-4.20.2):

1917b7f052dc7cb69f544e1f1ef94b48dd4212fb